Make voxel computation consistent across all source code (#354) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make voxel computation consistent across all source code, also use std::floor to have explicit control over type casting * Use available function for conversion * Make it a one liner * remove numeric from includes * New proposal * remove numeric from include * shrink diff * Consistency as always --------- Co-authored-by: tizianoGuadagnino <[email protected]> Co-authored-by: Ignacio Vizzo <[email protected]>
* Make voxel computation consistent across all source code, also use std::floor to have explicit control over type casting * Use available function for conversion * Remove redundant Modulus operation for Vocel Hash function, set robin map params instead * Make it a one liner * remove numeric from includes * New proposal * remove numeric from include * shrink diff * Consistency as always * Split changes into two PRs * Revert "Merge remote-tracking branch 'origin' into gupta_fix_hash" This reverts commit 6e46c0d, reversing changes made to 07634eb. --------- Co-authored-by: tizianoGuadagnino <[email protected]> Co-authored-by: Ignacio Vizzo <[email protected]>
* Add a new job just to proof the build is now broken * force 22.04 to make sure it's only a 20.04 problem * Revert "force 22.04 to make sure it's only a 20.04 problem" This reverts commit e1b5e02. * Add cache to ci build * Attempt to fix build in Ubuntu 20.04 * add this comment just to annoy ourselves
* Handled Zero Division Error * Apply suggestions from code review Co-authored-by: Benedikt Mersch <[email protected]> * Update pipeline.py updated pipeline.py based on @benemer suggestions where the results are only appended when avg fps is greater than zero * Fix formatting --------- Co-authored-by: Benedikt Mersch <[email protected]> Co-authored-by: tizianoGuadagnino <[email protected]>
* Make voxel computation consistent across all source code, also use std::floor to have explicit control over type casting * Use available function for conversion * Make it a one liner * remove numeric from includes * New proposal * remove numeric from include * shrink diff * Consistency as always * Fix include header, follow IWYU --------- Co-authored-by: tizianoGuadagnino <[email protected]> Co-authored-by: Ignacio Vizzo <[email protected]>
* Unify Voxel functionalities, now everything comes from VoxelHashMap * This looks like an even better unification * Modernize VoxelDownsample * VoxelUtils is born, now everthing is liteally in one place, and we have some side effect code reduction * Macos does not like my include * Local style include * With move * As of benchmark * For each for the win * Remove unnecessary include * Const correcteness * Refresh changes --------- Co-authored-by: Luca Lobefaro <[email protected]> Co-authored-by: Ignacio Vizzo <[email protected]>
* Unify Voxel functionalities, now everything comes from VoxelHashMap * This looks like an even better unification * Modernize VoxelDownsample * VoxelUtils is born, now everthing is liteally in one place, and we have some side effect code reduction * Macos does not like my include * Local style include * With move * As of benchmark * For each for the win * Remove unnecessary include * Const correcteness * Refresh changes * Add style changes for a separate PR * Add missing headers * Remove more raw for loops * Move Voxeldownsample into VoxelUtils * Cmake needs to know * Miss cpp * Remove duplicate * cmake-format * Format * We never used noexcept anywhere, why adding it now? * We always use frame, if we want to move point_cloud, let's do it in a seprate PR * put back whitespaces * reduce diff --------- Co-authored-by: tizianoGuadagnino <[email protected]> Co-authored-by: Luca Lobefaro <[email protected]> Co-authored-by: Benedikt Mersch <[email protected]>
* Remove kitti scan correction from core library Put it in python bindings, that is the only place where is actually used * Fix merge conflict
* Ofix: fix datalodaer * Ofix: bump ouster-sdk version * Ofix: make Python style happy * Ofix: more style happiness * Ofix: 0.11 sdk also works
* Add LiDAR odometry to tf tree * Transform the internal LiDAR odometry map to lidar frame I honestly do not know why this is not working, but we can see in the future. It's just to save so computation in the ROS node * Style
* Remove ugly unncessary python list appends * fix typo in name * Fix Visualizer * Satisfy style checker
* Bumb version * Finally 1.0.0 is here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make voxel computation consistent across all source code, also use std::floor to have explicit control over type casting
Use available function for conversion
Make it a one liner
remove numeric from includes
New proposal
remove numeric from include
shrink diff
Consistency as always