Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ouster dataloader for 0.11 - 0.12 sdk updates #372

Merged
merged 5 commits into from
Jul 24, 2024
Merged

Fix Ouster dataloader for 0.11 - 0.12 sdk updates #372

merged 5 commits into from
Jul 24, 2024

Conversation

bexcite
Copy link
Contributor

@bexcite bexcite commented Jul 24, 2024

Fixes the Ouster dataloader since they updated the SDK to some new primitives.

Tested with their public dataset using command:

kiss_icp_pipeline --deskew ~/data/ouster-sample-data/OS-0-128_v3.0.1_1024x10/OS-0-128_v3.0.1_1024x10_20230216_172749-000.pcap

with --visualize also works.

@bexcite bexcite changed the title Fix Ouster dataloader for 0.12.0 sdk update Fix Ouster dataloader for 0.11 - 0.12 sdk updates Jul 24, 2024
nachovizzo
nachovizzo approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@nachovizzo nachovizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pavlo!

benemer
benemer approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@benemer benemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@benemer benemer merged commit 0276c90 into PRBonn:main Jul 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benemer benemer benemer approved these changes

@tizianoGuadagnino tizianoGuadagnino tizianoGuadagnino approved these changes

@nachovizzo nachovizzo nachovizzo approved these changes

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bexcite @nachovizzo @tizianoGuadagnino @benemer