add import prop @ FileMigrationProvider.
#994
Open
+10,082
−681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
igalklebanov
changed the title
import prop @ FileMigrationProvider.
igalklebanov
force-pushed
the
pass-import-fn-migration-provider
branch
from
d3cf478 to
ddfe24e
Compare
igalklebanov
added
enhancement
igalklebanov
commented
May 19, 2024
| @@ -2,7 +2,8 @@ | |||
| "extends": "../../tsconfig-base.json", | |||
| "include": ["src/**/*"], | |||
| "compilerOptions": { | |||
| "module": "CommonJS", | |||
| "outDir": "dist" | |||
| "module": "NodeNext", | |||
There was a problem hiding this comment.
necessary to allow importing tsx/*.
igalklebanov
commented
May 19, 2024
Comment on lines
+2
to
+7
| import chaiAsPromised from 'chai-as-promised' | ||
| import chaiSubset from 'chai-subset' | ||
| import Cursor from 'pg-cursor' | ||
| import { Pool, PoolConfig } from 'pg' | ||
| import { createPool } from 'mysql2' | ||
| import * as Database from 'better-sqlite3' | ||
| import Database from 'better-sqlite3' |
There was a problem hiding this comment.
necessary after tsconfig changes.
igalklebanov
force-pushed
the
pass-import-fn-migration-provider
branch
from
1003a53 to
1994fbb
Compare
|
This would help so much! |
igalklebanov
force-pushed
the
pass-import-fn-migration-provider
branch
from
8b9ab06 to
49e8f06
Compare
…kysely-org#1085) * add reusable helpers recipe and implement missing expression features * force node 22.4.1 in CI because of an npm bug
* feat: add postgres range types (kysely-org#1086) * feat: support refresh naterialized view * fix tests by adding .materialized() to remove the matview * fix failing test * fix: References typo (kysely-org#1092) * chore: refresh-view-node.ts => refresh-materialized-view-node.ts * chore: export node in index.ts --------- Co-authored-by: Isak <[email protected]> Co-authored-by: Jonathan Wu <[email protected]>
Co-authored-by: Igal Klebanov <[email protected]>
.. add FileMigrationProvider test suite. ..
igalklebanov
force-pushed
the
pass-import-fn-migration-provider
branch
from
49e8f06 to
ca167d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
This PR allows passing an optional custom
importfunction @FileMigrationProvider.e.g. this would allow consumers to pass a function that uses
tsImportbytsxto import TS files without the need to precompile them when using Node.js or a similar JavaScript runtime that doesn't have built-in TS file support.Also adds
onDiscardedoptional prop, so external tooling can warn users about files that were ignored by the migration provider.Also extracts file extension check to a protected method - can be overridden to only support TS files by an extending class.
Also adds
cjs&ctssupport.These changes were inspired by https://github.com/kysely-org/kysely-ctl/blob/main/src/kysely/ts-file-migration-provider.mts , a custom provider implementation in
kysely-ctlthat only works with TS migration files, on all runtimes.