Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support refresh materialized view #990

Merged
merged 8 commits into from
Aug 2, 2024

Conversation

QuentinJanuel
Copy link

Hi, this PR adds the functionality to refresh materialized views!

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 7:30am

@QuentinJanuel
Copy link
Author

@koskimas @igalklebanov Sorry am I missing anything regarding the contributions guidelines? Please tell me if there is any issue with this PR so that I can fix it

@igalklebanov
Copy link
Member

Hey 👋

Sorry for the delay, IRL stuff. Overall, it looks good. Let's get those tests 🟢.

@QuentinJanuel
Copy link
Author

Okay I think I fixed the tests, they were not passing because I was trying to drop a materialized view without specifying .materialized().
I cannot run the tests locally though so I'm sorry if we're still not done yet 😕

@QuentinJanuel
Copy link
Author

Sorry for taking so much time. There were still one failing test left, but this time hopefully everything will pass 🤞

@koskimas koskimas changed the base branch from master to v0.28 July 27, 2024 07:38
Copy link
Member

@koskimas koskimas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased this to v0.28. You need to export the node from the index.ts file to make the tests on that branch pass. Then this is good to go.

src/operation-node/refresh-view-node.ts Outdated Show resolved Hide resolved
@koskimas koskimas merged commit e60c8b7 into kysely-org:v0.28 Aug 2, 2024
11 checks passed
igalklebanov pushed a commit that referenced this pull request Aug 25, 2024
* feat: add postgres range types (#1086)

* feat: support refresh naterialized view

* fix tests by adding .materialized() to remove the matview

* fix failing test

* fix: References typo (#1092)

* chore: refresh-view-node.ts => refresh-materialized-view-node.ts

* chore: export node in index.ts

---------

Co-authored-by: Isak <[email protected]>
Co-authored-by: Jonathan Wu <[email protected]>
igalklebanov pushed a commit that referenced this pull request Aug 25, 2024
* feat: add postgres range types (#1086)

* feat: support refresh naterialized view

* fix tests by adding .materialized() to remove the matview

* fix failing test

* fix: References typo (#1092)

* chore: refresh-view-node.ts => refresh-materialized-view-node.ts

* chore: export node in index.ts

---------

Co-authored-by: Isak <[email protected]>
Co-authored-by: Jonathan Wu <[email protected]>
igalklebanov pushed a commit that referenced this pull request Oct 3, 2024
* feat: add postgres range types (#1086)

* feat: support refresh naterialized view

* fix tests by adding .materialized() to remove the matview

* fix failing test

* fix: References typo (#1092)

* chore: refresh-view-node.ts => refresh-materialized-view-node.ts

* chore: export node in index.ts

---------

Co-authored-by: Isak <[email protected]>
Co-authored-by: Jonathan Wu <[email protected]>
igalklebanov pushed a commit that referenced this pull request Oct 3, 2024
* feat: add postgres range types (#1086)

* feat: support refresh naterialized view

* fix tests by adding .materialized() to remove the matview

* fix failing test

* fix: References typo (#1092)

* chore: refresh-view-node.ts => refresh-materialized-view-node.ts

* chore: export node in index.ts

---------

Co-authored-by: Isak <[email protected]>
Co-authored-by: Jonathan Wu <[email protected]>
igalklebanov pushed a commit to igalklebanov/kysely that referenced this pull request Oct 4, 2024
* feat: add postgres range types (kysely-org#1086)

* feat: support refresh naterialized view

* fix tests by adding .materialized() to remove the matview

* fix failing test

* fix: References typo (kysely-org#1092)

* chore: refresh-view-node.ts => refresh-materialized-view-node.ts

* chore: export node in index.ts

---------

Co-authored-by: Isak <[email protected]>
Co-authored-by: Jonathan Wu <[email protected]>
igalklebanov pushed a commit that referenced this pull request Oct 12, 2024
* feat: add postgres range types (#1086)

* feat: support refresh naterialized view

* fix tests by adding .materialized() to remove the matview

* fix failing test

* fix: References typo (#1092)

* chore: refresh-view-node.ts => refresh-materialized-view-node.ts

* chore: export node in index.ts

---------

Co-authored-by: Isak <[email protected]>
Co-authored-by: Jonathan Wu <[email protected]>
igalklebanov pushed a commit that referenced this pull request Oct 19, 2024
* feat: add postgres range types (#1086)

* feat: support refresh naterialized view

* fix tests by adding .materialized() to remove the matview

* fix failing test

* fix: References typo (#1092)

* chore: refresh-view-node.ts => refresh-materialized-view-node.ts

* chore: export node in index.ts

---------

Co-authored-by: Isak <[email protected]>
Co-authored-by: Jonathan Wu <[email protected]>
igalklebanov pushed a commit that referenced this pull request Oct 24, 2024
* feat: add postgres range types (#1086)

* feat: support refresh naterialized view

* fix tests by adding .materialized() to remove the matview

* fix failing test

* fix: References typo (#1092)

* chore: refresh-view-node.ts => refresh-materialized-view-node.ts

* chore: export node in index.ts

---------

Co-authored-by: Isak <[email protected]>
Co-authored-by: Jonathan Wu <[email protected]>
igalklebanov pushed a commit that referenced this pull request Oct 24, 2024
* feat: add postgres range types (#1086)

* feat: support refresh naterialized view

* fix tests by adding .materialized() to remove the matview

* fix failing test

* fix: References typo (#1092)

* chore: refresh-view-node.ts => refresh-materialized-view-node.ts

* chore: export node in index.ts

---------

Co-authored-by: Isak <[email protected]>
Co-authored-by: Jonathan Wu <[email protected]>
igalklebanov pushed a commit that referenced this pull request Oct 27, 2024
* feat: add postgres range types (#1086)

* feat: support refresh naterialized view

* fix tests by adding .materialized() to remove the matview

* fix failing test

* fix: References typo (#1092)

* chore: refresh-view-node.ts => refresh-materialized-view-node.ts

* chore: export node in index.ts

---------

Co-authored-by: Isak <[email protected]>
Co-authored-by: Jonathan Wu <[email protected]>
igalklebanov pushed a commit that referenced this pull request Nov 2, 2024
* feat: add postgres range types (#1086)

* feat: support refresh naterialized view

* fix tests by adding .materialized() to remove the matview

* fix failing test

* fix: References typo (#1092)

* chore: refresh-view-node.ts => refresh-materialized-view-node.ts

* chore: export node in index.ts

---------

Co-authored-by: Isak <[email protected]>
Co-authored-by: Jonathan Wu <[email protected]>
igalklebanov pushed a commit that referenced this pull request Nov 24, 2024
* feat: add postgres range types (#1086)

* feat: support refresh naterialized view

* fix tests by adding .materialized() to remove the matview

* fix failing test

* fix: References typo (#1092)

* chore: refresh-view-node.ts => refresh-materialized-view-node.ts

* chore: export node in index.ts

---------

Co-authored-by: Isak <[email protected]>
Co-authored-by: Jonathan Wu <[email protected]>
igalklebanov pushed a commit that referenced this pull request Dec 1, 2024
* feat: add postgres range types (#1086)

* feat: support refresh naterialized view

* fix tests by adding .materialized() to remove the matview

* fix failing test

* fix: References typo (#1092)

* chore: refresh-view-node.ts => refresh-materialized-view-node.ts

* chore: export node in index.ts

---------

Co-authored-by: Isak <[email protected]>
Co-authored-by: Jonathan Wu <[email protected]>
igalklebanov pushed a commit that referenced this pull request Dec 8, 2024
* feat: add postgres range types (#1086)

* feat: support refresh naterialized view

* fix tests by adding .materialized() to remove the matview

* fix failing test

* fix: References typo (#1092)

* chore: refresh-view-node.ts => refresh-materialized-view-node.ts

* chore: export node in index.ts

---------

Co-authored-by: Isak <[email protected]>
Co-authored-by: Jonathan Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to library's API enhancement New feature or request postgres Related to PostgreSQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants