Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove validating webhook deletion logic #1684

Merged
merged 3 commits into from
Dec 16, 2024
Merged

chore: Remove validating webhook deletion logic #1684

merged 3 commits into from
Dec 16, 2024

Conversation

skhalash
Copy link
Collaborator

@skhalash skhalash commented Dec 16, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@skhalash skhalash added kind/chore Categorizes issue or PR as related to a chore. area/logs LogPipeline labels Dec 16, 2024
@skhalash skhalash added this to the 1.30.0 milestone Dec 16, 2024
@skhalash skhalash requested a review from a team as a code owner December 16, 2024 14:13
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 16, 2024
@k15r k15r self-assigned this Dec 16, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 16, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 16, 2024
@skhalash skhalash merged commit d7671ca into kyma-project:main Dec 16, 2024
42 checks passed
jeffreylimnardy pushed a commit to jeffreylimnardy/telemetry-manager that referenced this pull request Dec 18, 2024
@skhalash @jeffreylimnardy
chore: Remove validating webhook deletion logic (kyma-project#1684)
e3dcadc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k15r k15r k15r approved these changes

Assignees

@k15r k15r

Labels
area/logs LogPipeline cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.30.0
Development

Successfully merging this pull request may close these issues.
3 participants
@skhalash @k15r @kyma-bot