generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migrate validating webhook to kustomize #1617
Merged
skhalash
merged 24 commits into
kyma-project:main
from
shorim:migrate_validating_webhook_to_kustomize
Nov 21, 2024
Merged
chore: Migrate validating webhook to kustomize #1617
skhalash
merged 24 commits into
kyma-project:main
from
shorim:migrate_validating_webhook_to_kustomize
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorim
added
kind/chore
Categorizes issue or PR as related to a chore.
area/logs
LogPipeline
labels
Nov 19, 2024
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Nov 19, 2024
shorim
changed the title
Chore: Migrate validating webhook to kustomize
chore: Migrate validating webhook to kustomize
Nov 19, 2024
…bhook_to_kustomize
skhalash
reviewed
Nov 20, 2024
kyma-bot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Nov 20, 2024
…bhook_to_kustomize
…bhook_to_kustomize
skhalash
approved these changes
Nov 21, 2024
New changes are detected. LGTM label has been removed. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/logs
LogPipeline
cla: yes
Indicates the PR's author has signed the CLA.
kind/chore
Categorizes issue or PR as related to a chore.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request (what was done and why):
validation.webhook.telemetry.kyma-project.io
totelemetry-validating-webhook.kyma-project.io
, the old validating webhook is deleted in the Telemetry reconcilerupdate
request instead ofpatch
request for simplicity and making it consistent with updating the validating webhook with CA bundleChanges refer to particular issues, PRs or documents:
Traceability
Related Issues
section.