feat: Add mutating webhook and defaulter for all signal types

.golangci.yaml

@@ -65,10 +65,20 @@ linters-settings:
         alias: kitk8s
       - pkg: github.com/kyma-project/telemetry-manager/test/testkit/kyma
         alias: kitkyma
-      - pkg: github.com/kyma-project/telemetry-manager/webhook/logparser
-        alias: logparserwebhook
-      - pkg: github.com/kyma-project/telemetry-manager/webhook/logpipeline
-        alias: logpipelinewebhook
+      - pkg: github.com/kyma-project/telemetry-manager/webhook/logparser/v1alpha1
+        alias: logparserwebhookv1alpha1
+      - pkg: github.com/kyma-project/telemetry-manager/webhook/logpipeline/v1alpha1
+        alias: logpipelinewebhookv1alpha1
+      - pkg: github.com/kyma-project/telemetry-manager/webhook/logpipeline/v1beta1
+        alias: logpipelinewebhookv1beta1
+      - pkg: github.com/kyma-project/telemetry-manager/webhook/metricpipeline/v1alpha1
+        alias: metricpipelinewebhookv1alpha1
+      - pkg: github.com/kyma-project/telemetry-manager/webhook/metricpipeline/v1beta1
+        alias: metricpipelinewebhookv1beta1
+      - pkg: github.com/kyma-project/telemetry-manager/webhook/tracepipeline/v1alpha1
+        alias: tracepipelinewebhookv1alpha1
+      - pkg: github.com/kyma-project/telemetry-manager/webhook/tracepipeline/v1beta1
+        alias: tracepipelinewebhookv1beta1
       - pkg: github.com/kyma-project/telemetry-manager/internal/reconciler/logpipeline/fluentbit
         alias: logpipelinefluentbit
       - pkg: github.com/prometheus/client_golang/api/prometheus/v1

.testcoverage.yml

@@ -45,10 +45,17 @@ override:
     path: ^internal/resourcelock$
   - threshold: 84
     path: ^internal/webhookcert$
-  - threshold: 73
-    path: ^webhook/logpipeline$
+  - threshold: 87
+    path: ^webhook/logpipeline/v1alpha1$
+  - threshold: 84
+    path: ^webhook/logpipeline/v1beta1$
   - threshold: 83
     path: ^internal/utils/logpipeline$
+  - threshold: 75
+    path: ^webhook/tracepipeline/v1alpha1$
+  - threshold: 75
+    path: ^webhook/tracepipeline/v1beta1$
+
 
 # Holds regexp rules which will exclude matched files or packages from coverage statistics
 exclude:

apis/telemetry/v1alpha1/logpipeline_types.go

@@ -77,7 +77,6 @@ type LogPipelineInput struct {
 type LogPipelineApplicationInput struct {
 	// If enabled, application logs are collected. The default is `true`.
 	// +optional
-	// +kubebuilder:default=true
 	Enabled *bool `json:"enabled,omitempty"`
 	// Describes whether application logs from specific Namespaces are selected. The options are mutually exclusive. System Namespaces are excluded by default from the collection.
 	Namespaces LogPipelineNamespaceSelector `json:"namespaces,omitempty"`
@@ -89,7 +88,6 @@ type LogPipelineApplicationInput struct {
 	DropLabels bool `json:"dropLabels,omitempty"`
 	// If the `log` attribute contains a JSON payload and it is successfully parsed, the `log` attribute will be retained if `KeepOriginalBody` is set to `true`. Otherwise, the log attribute will be removed from the log record. The default is `true`.
 	// +optional
-	// +kubebuilder:default=true
 	KeepOriginalBody *bool `json:"keepOriginalBody,omitempty"`
 }
 

apis/telemetry/v1alpha1/metricpipeline_types.go

@@ -85,7 +85,6 @@ type MetricPipelinePrometheusInput struct {
 	Enabled bool `json:"enabled,omitempty"`
 	// Describes whether Prometheus metrics from specific namespaces are selected. System namespaces are disabled by default.
 	// +optional
-	// +kubebuilder:default={exclude: {kyma-system, kube-system, istio-system, compass-system}}
 	Namespaces *NamespaceSelector `json:"namespaces,omitempty"`
 	// Configures diagnostic metrics scraping
 	// +optional
@@ -98,55 +97,44 @@ type MetricPipelineRuntimeInput struct {
 	Enabled bool `json:"enabled,omitempty"`
 	// Describes whether runtime metrics from specific namespaces are selected. System namespaces are disabled by default.
 	// +optional
-	// +kubebuilder:default={exclude: {kyma-system, kube-system, istio-system, compass-system}}
 	Namespaces *NamespaceSelector `json:"namespaces,omitempty"`
 	// Describes the Kubernetes resources for which runtime metrics are scraped.
 	// +optional
-	// +kubebuilder:default={pod: {enabled: true}, container: {enabled: true}, node: {enabled: true}, volume: {enabled: true}, daemonset: {enabled: true}, deployment: {enabled: true}, statefulset: {enabled: true}, job: {enabled: true}}
 	Resources *MetricPipelineRuntimeInputResources `json:"resources,omitempty"`
 }
 
 // MetricPipelineRuntimeInputResources describes the Kubernetes resources for which runtime metrics are scraped.
 type MetricPipelineRuntimeInputResources struct {
 	// Configures Pod runtime metrics scraping.
 	// +optional
-	// +kubebuilder:default={enabled: true}
-	Pod *MetricPipelineRuntimeInputResourceEnabledByDefault `json:"pod,omitempty"`
+	Pod *MetricPipelineRuntimeInputResource `json:"pod,omitempty"`
 	// Configures container runtime metrics scraping.
 	// +optional
-	// +kubebuilder:default={enabled: true}
-	Container *MetricPipelineRuntimeInputResourceEnabledByDefault `json:"container,omitempty"`
+	Container *MetricPipelineRuntimeInputResource `json:"container,omitempty"`
 	// Configures Node runtime metrics scraping.
 	// +optional
-	// +kubebuilder:default={enabled: true}
-	Node *MetricPipelineRuntimeInputResourceEnabledByDefault `json:"node,omitempty"`
+	Node *MetricPipelineRuntimeInputResource `json:"node,omitempty"`
 	// Configures Volume runtime metrics scraping.
 	// +optional
-	// +kubebuilder:default={enabled: true}
-	Volume *MetricPipelineRuntimeInputResourceEnabledByDefault `json:"volume,omitempty"`
+	Volume *MetricPipelineRuntimeInputResource `json:"volume,omitempty"`
 	// Configures DaemonSet runtime metrics scraping.
 	// +optional
-	// +kubebuilder:default={enabled: true}
-	DaemonSet *MetricPipelineRuntimeInputResourceEnabledByDefault `json:"daemonset,omitempty"`
+	DaemonSet *MetricPipelineRuntimeInputResource `json:"daemonset,omitempty"`
 	// Configures Deployment runtime metrics scraping.
 	// +optional
-	// +kubebuilder:default={enabled: true}
-	Deployment *MetricPipelineRuntimeInputResourceEnabledByDefault `json:"deployment,omitempty"`
+	Deployment *MetricPipelineRuntimeInputResource `json:"deployment,omitempty"`
 	// Configures StatefulSet runtime metrics scraping.
 	// +optional
-	// +kubebuilder:default={enabled: true}
-	StatefulSet *MetricPipelineRuntimeInputResourceEnabledByDefault `json:"statefulset,omitempty"`
+	StatefulSet *MetricPipelineRuntimeInputResource `json:"statefulset,omitempty"`
 	// Configures Job runtime metrics scraping.
 	// +optional
-	// +kubebuilder:default={enabled: true}
-	Job *MetricPipelineRuntimeInputResourceEnabledByDefault `json:"job,omitempty"`
+	Job *MetricPipelineRuntimeInputResource `json:"job,omitempty"`
 }
 
-// MetricPipelineRuntimeInputResourceEnabledByDefault defines if the scraping of runtime metrics is enabled for a specific resource. The scraping is enabled by default.
-type MetricPipelineRuntimeInputResourceEnabledByDefault struct {
+// MetricPipelineRuntimeInputResource defines if the scraping of runtime metrics is enabled for a specific resource. The scraping is enabled by default.
+type MetricPipelineRuntimeInputResource struct {
 	// If enabled, the runtime metrics for the resource are scraped. The default is `true`.
 	// +optional
-	// +kubebuilder:default=true
 	Enabled *bool `json:"enabled,omitempty"`
 }
 

apis/telemetry/v1alpha1/shared_types.go

@@ -34,7 +34,6 @@ const (
 type OTLPOutput struct {
 	// Defines the OTLP protocol (http or grpc). Default is grpc.
 	// +kubebuilder:validation:MinLength=1
-	// +kubebuilder:default:=grpc
 	// +kubebuilder:validation:Enum=grpc;http
 	Protocol string `json:"protocol,omitempty"`
 	// Defines the host and port (<host>:<port>) of an OTLP endpoint.

apis/telemetry/v1beta1/logpipeline_types.go

@@ -84,7 +84,6 @@ type LogPipelineInput struct {
 type LogPipelineRuntimeInput struct {
 	// If enabled, application logs are collected. The default is `true`.
 	// +optional
-	// +kubebuilder:default=true
 	Enabled *bool `json:"enabled,omitempty"`
 	// Describes whether application logs from specific Namespaces are selected. The options are mutually exclusive. System Namespaces are excluded by default from the collection.
 	Namespaces LogPipelineNamespaceSelector `json:"namespaces,omitempty"`
@@ -96,7 +95,6 @@ type LogPipelineRuntimeInput struct {
 	DropLabels bool `json:"dropLabels,omitempty"`
 	// If the `log` attribute contains a JSON payload and it is successfully parsed, the `log` attribute will be retained if `keepOriginalBody` is set to `true`. Otherwise, the log attribute will be removed from the log record. The default is `true`.
 	// +optional
-	// +kubebuilder:default=true
 	KeepOriginalBody *bool `json:"keepOriginalBody,omitempty"`
 }
 

apis/telemetry/v1beta1/metricpipeline_types.go

@@ -85,7 +85,6 @@ type MetricPipelinePrometheusInput struct {
 	Enabled bool `json:"enabled,omitempty"`
 	// Describes whether Prometheus metrics from specific namespaces are selected. System namespaces are disabled by default.
 	// +optional
-	// +kubebuilder:default={exclude: {kyma-system, kube-system, istio-system, compass-system}}
 	Namespaces *NamespaceSelector `json:"namespaces,omitempty"`
 	// Configures diagnostic metrics scraping
 	// +optional
@@ -98,55 +97,44 @@ type MetricPipelineRuntimeInput struct {
 	Enabled bool `json:"enabled,omitempty"`
 	// Describes whether runtime metrics from specific namespaces are selected. System namespaces are disabled by default.
 	// +optional
-	// +kubebuilder:default={exclude: {kyma-system, kube-system, istio-system, compass-system}}
 	Namespaces *NamespaceSelector `json:"namespaces,omitempty"`
 	// Describes the Kubernetes resources for which runtime metrics are scraped.
 	// +optional
-	// +kubebuilder:default={pod: {enabled: true}, container: {enabled: true}, node: {enabled: true}, volume: {enabled: true}, daemonset: {enabled: true}, deployment: {enabled: true}, statefulset: {enabled: true}, job: {enabled: true}}
 	Resources *MetricPipelineRuntimeInputResources `json:"resources,omitempty"`
 }
 
 // MetricPipelineRuntimeInputResources describes the Kubernetes resources for which runtime metrics are scraped.
 type MetricPipelineRuntimeInputResources struct {
 	// Configures Pod runtime metrics scraping.
 	// +optional
-	// +kubebuilder:default={enabled: true}
-	Pod *MetricPipelineRuntimeInputResourceEnabledByDefault `json:"pod,omitempty"`
+	Pod *MetricPipelineRuntimeInputResource `json:"pod,omitempty"`
 	// Configures container runtime metrics scraping.
 	// +optional
-	// +kubebuilder:default={enabled: true}
-	Container *MetricPipelineRuntimeInputResourceEnabledByDefault `json:"container,omitempty"`
+	Container *MetricPipelineRuntimeInputResource `json:"container,omitempty"`
 	// Configures Node runtime metrics scraping.
 	// +optional
-	// +kubebuilder:default={enabled: true}
-	Node *MetricPipelineRuntimeInputResourceEnabledByDefault `json:"node,omitempty"`
+	Node *MetricPipelineRuntimeInputResource `json:"node,omitempty"`
 	// Configures Volume runtime metrics scraping.
 	// +optional
-	// +kubebuilder:default={enabled: true}
-	Volume *MetricPipelineRuntimeInputResourceEnabledByDefault `json:"volume,omitempty"`
+	Volume *MetricPipelineRuntimeInputResource `json:"volume,omitempty"`
 	// Configures DaemonSet runtime metrics scraping.
 	// +optional
-	// +kubebuilder:default={enabled: true}
-	DaemonSet *MetricPipelineRuntimeInputResourceEnabledByDefault `json:"daemonset,omitempty"`
+	DaemonSet *MetricPipelineRuntimeInputResource `json:"daemonset,omitempty"`
 	// Configures Deployment runtime metrics scraping.
 	// +optional
-	// +kubebuilder:default={enabled: true}
-	Deployment *MetricPipelineRuntimeInputResourceEnabledByDefault `json:"deployment,omitempty"`
+	Deployment *MetricPipelineRuntimeInputResource `json:"deployment,omitempty"`
 	// Configures StatefulSet runtime metrics scraping.
 	// +optional
-	// +kubebuilder:default={enabled: true}
-	StatefulSet *MetricPipelineRuntimeInputResourceEnabledByDefault `json:"statefulset,omitempty"`
+	StatefulSet *MetricPipelineRuntimeInputResource `json:"statefulset,omitempty"`
 	// Configures Job runtime metrics scraping.
 	// +optional
-	// +kubebuilder:default={enabled: true}
-	Job *MetricPipelineRuntimeInputResourceEnabledByDefault `json:"job,omitempty"`
+	Job *MetricPipelineRuntimeInputResource `json:"job,omitempty"`
 }
 
-// MetricPipelineRuntimeInputResourceEnabledByDefault defines if the scraping of runtime metrics is enabled for a specific resource. The scraping is enabled by default.
-type MetricPipelineRuntimeInputResourceEnabledByDefault struct {
+// MetricPipelineRuntimeInputResource defines if the scraping of runtime metrics is enabled for a specific resource. The scraping is enabled by default.
+type MetricPipelineRuntimeInputResource struct {
 	// If enabled, the runtime metrics for the resource are scraped. The default is `true`.
 	// +optional
-	// +kubebuilder:default=true
 	Enabled *bool `json:"enabled,omitempty"`
 }
 

apis/telemetry/v1beta1/shared_types.go

@@ -35,7 +35,6 @@ const (
 // +kubebuilder:validation:XValidation:rule="((!has(self.path) || size(self.path) <= 0) && (has(self.protocol) && self.protocol == 'grpc')) || (has(self.protocol) && self.protocol == 'http')", message="Path is only available with HTTP protocol"
 type OTLPOutput struct {
 	// Defines the OTLP protocol (http or grpc). Default is grpc.
-	// +kubebuilder:default:=grpc
 	// +kubebuilder:validation:Enum=grpc;http
 	Protocol OTLPProtocol `json:"protocol,omitempty"`
 	// Defines the host and port (<host>:<port>) of an OTLP endpoint.