Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add mutating webhook and defaulter for all signal types #1613

Merged
merged 49 commits into from
Nov 22, 2024
Merged

feat: Add mutating webhook and defaulter for all signal types #1613

merged 49 commits into from
Nov 22, 2024

Conversation

hisarbalik
Copy link
Contributor

@hisarbalik hisarbalik commented Nov 18, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Add mutating webhook for MetricPipeline
  • Add defaulting webhook implementation for MetricPipeline for both version v1alpha1 and v1beta1
  • Add mutating webhook for TracePipeline
  • Add defaulting webhook implementation for TracePipeline for both version v1alpha1 and v1beta1
  • Add mutating webhook for LogPipeline
  • Add defaulting webhook implementation for LogPipeline for both version v1alpha1 and v1beta1

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@hisarbalik hisarbalik requested a review from a team as a code owner November 18, 2024 19:36
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 18, 2024
@hisarbalik hisarbalik mentioned this pull request Nov 18, 2024
Closed
6 tasks
@hisarbalik hisarbalik added kind/feature Categorizes issue or PR as related to a new feature. area/metrics MetricPipeline area/manager Manager or module changes labels Nov 18, 2024
@hisarbalik hisarbalik added this to the 1.29.0 milestone Nov 18, 2024
@hisarbalik hisarbalik changed the title feat: Add mutating webhook for MetricPipeline feat: Add mutating webhook Nov 19, 2024
@hisarbalik hisarbalik changed the title feat: Add mutating webhook feat: Add mutating webhook and defaulter for all signal types Nov 19, 2024
@hisarbalik hisarbalik added area/logs LogPipeline area/traces TracePipeline labels Nov 19, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 19, 2024
@hisarbalik hisarbalik requested a review from shorim November 22, 2024 12:24
@hisarbalik hisarbalik requested a review from shorim November 22, 2024 12:36
@hisarbalik hisarbalik requested a review from shorim November 22, 2024 14:53
@hisarbalik hisarbalik enabled auto-merge (squash) November 22, 2024 16:10
@hisarbalik hisarbalik merged commit 90cf6e6 into kyma-project:main Nov 22, 2024
37 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 22, 2024
@hisarbalik hisarbalik deleted the add-metricpipeline-defaulting-webhook branch November 22, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorim shorim shorim approved these changes

Assignees

@shorim shorim

Labels
area/logs LogPipeline area/manager Manager or module changes area/metrics MetricPipeline area/traces TracePipeline cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
1.29.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hisarbalik @shorim @kyma-bot