Refactor SKR watcher installation to use native Kubernetes client #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o watcher-reconciles-kymas # Conflicts: # operator/internal/deploy/chart_manager.go
…atcher-reconciles-kymas
fourthisle
changed the title
kyma-bot
removed
the
do-not-merge/work-in-progress
fourthisle
changed the title
|
/test pull-lifecycle-mgr-tests |
fourthisle
changed the title
pkg/deploy/template_chart_manager.go
Outdated
| return true, err | ||
| } | ||
| for _, resource := range resources { | ||
| err := syncContext.RuntimeClient.Patch(ctx, resource, client.Apply, client.ForceOwnership, skrChartFieldOwner) |
There was a problem hiding this comment.
would you kindly update this to a concurrent implementation using ErrGroup? otherwise we will have to wait for each resource patch to complete, which develops bottlenecking here
pkg/deploy/template_chart_manager.go
Outdated
Comment on lines
101
to
104
| if err := syncContext.RuntimeClient.Delete(ctx, resource); err != nil && !apierrors.IsNotFound(err) { | ||
| return fmt.Errorf("failed to delete webhook %s: %w", resource.GetKind(), err) | ||
| } | ||
| } |
There was a problem hiding this comment.
does it make sense to implement similar errGrp here, so that deletion of following resources are not blocked by one failing?
adityabhatia
approved these changes
Jan 23, 2023
jakobmoellerdev
added a commit
to jakobmoellerdev/kyma-operator
that referenced
this pull request
Jan 24, 2023
…ient (kyma-project#313)" This reverts commit 4643b27.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation of #301