Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SKR watcher installation to use native Kubernetes client #301

Closed
5 tasks done
fourthisle opened this issue Nov 7, 2022 · 1 comment
Closed
5 tasks done

Refactor SKR watcher installation to use native Kubernetes client #301

fourthisle opened this issue Nov 7, 2022 · 1 comment
Assignees
@adityabhatia @fourthisle

Comments

@fourthisle
Copy link
Contributor

fourthisle commented Nov 7, 2022 •
edited by jeremyharisch
Loading

Description
Using the native Kubernetes client to install the SKR watcher should be implemented and relying on the manifest library should be removed.

ACs

  • Remove dependency between SKR chart installation and the manifest library and use native Kubernetes client instead.
  • Use trigger label with secretResourceVersion value to ensure pods restart when chart is redeployed.
  • Use sync context on Kyma reconciler setup and pass it to ChartManager method calls as needed
  • The SKR web-hook's installation should leverage SSA to be idempotent.

And ensure that:

  • the caBundle configured for each deployed webhook configuration is the same as the ca.crt field of the tls-secret

Related discussions

#277 (comment)
#277 (comment)
#277 (comment)

PR
#313
@fourthisle fourthisle mentioned this issue Nov 7, 2022
Merged
7 tasks
@jakobmoellerdev
Copy link
Contributor

Please fill TBD fields @khlifi411

@fourthisle fourthisle linked a pull request Nov 16, 2022 that will close this issue
Refactor SKR watcher installation to use native Kubernetes client #313
Merged
@fourthisle fourthisle changed the title Implement custom consistency checks for SKR chart manager Implement caching and custom consistency checks for SKR chart manager Nov 17, 2022
@fourthisle fourthisle mentioned this issue Nov 17, 2022
Closed
1 task
@fourthisle fourthisle self-assigned this Dec 14, 2022
@fourthisle fourthisle removed a link to a pull request Jan 12, 2023
Refactor SKR watcher installation to use native Kubernetes client #313
Merged
@fourthisle fourthisle mentioned this issue Jan 12, 2023
Merged
@fourthisle fourthisle changed the title Implement caching and custom consistency checks for SKR chart manager Refactor SKR watcher installation to use native Kubernetes client Jan 12, 2023
@fourthisle fourthisle assigned fourthisle and unassigned fourthisle Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adityabhatia adityabhatia

@fourthisle fourthisle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@adityabhatia @fourthisle @jeremyharisch @jakobmoellerdev