Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET and DELETE in Kyma Binding SKR test #1249

Merged
merged 12 commits into from
Oct 8, 2024
Merged

GET and DELETE in Kyma Binding SKR test #1249

merged 12 commits into from
Oct 8, 2024

Conversation

KsaweryZietara
Copy link
Contributor

@KsaweryZietara KsaweryZietara commented Oct 3, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Kubernetes TokenRequest: test get binding, delete binding and fetch secret using kubeconfig after binding deletion - it should fail,
  • Gardener admin kubeconfig: test get binding, delete binding and fetch secret using kubecofnig after binding deletion - it should pass (it is not possible to invalidate admin kubeconfig).

Related issue(s)
See also #1204

@KsaweryZietara KsaweryZietara added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Oct 3, 2024
@KsaweryZietara KsaweryZietara self-assigned this Oct 3, 2024
@KsaweryZietara KsaweryZietara requested a review from a team as a code owner October 3, 2024 12:04
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. labels Oct 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) October 3, 2024 12:04
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 3, 2024
@KsaweryZietara KsaweryZietara mentioned this pull request Oct 3, 2024
Closed
5 tasks
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 3, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 8, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit fa7d12c into kyma-project:main Oct 8, 2024
25 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralikio ralikio ralikio approved these changes

Assignees

@ralikio ralikio

@KsaweryZietara KsaweryZietara

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KsaweryZietara @ralikio @kyma-bot @kyma-gopher-bot