Use chai-as-promised to check if functions threw an error

KsaweryZietara · Oct 3, 2024 · 4d3fffa · 4d3fffa
1 parent 450c9be
commit 4d3fffa
Show file tree

Hide file tree

Showing 3 changed files with 48 additions and 43 deletions.
diff --git a/testing/e2e/skr/package-lock.json b/testing/e2e/skr/package-lock.json
diff --git a/testing/e2e/skr/package.json b/testing/e2e/skr/package.json
@@ -28,6 +28,7 @@
   "dependencies": {
     "@kubernetes/client-node": "0.15.1",
     "axios": "^1.7.4",
+    "chai-as-promised": "^8.0.0",
     "js-yaml": "^4.1.0",
     "mocha-junit-reporter": "^2.0.0",
     "node-forge": "^1.3.1",

diff --git a/testing/e2e/skr/skr-binding-test/index.js b/testing/e2e/skr/skr-binding-test/index.js
@@ -1,4 +1,6 @@
 const {expect} = require('chai');
+const chaiAsPromised = require('chai-as-promised');
+chai.use(chaiAsPromised);
 const {gatherOptions} = require('../skr-test');
 const {initializeK8sClient} = require('../utils/index.js');
 const {getSecret, getKubeconfigValidityInSeconds} = require('../utils');
@@ -56,23 +58,11 @@ describe('SKR Binding test', function() {
   });
 
   it('Try to fetch SKR binding created using Kubernetes TokenRequest', async function() {
-    try {
-      await keb.getBinding(options.instanceID, bindingID);
-      fail('KEB must return an error');
-    } catch (err) {
-      expect(err.response.status).equal(404);
-      console.log('Got response:');
-      console.log(err.response.data);
-    }
+    await expect(keb.getBinding(options.instanceID, bindingID)).to.be.rejectedWith(Error);
   });
 
   it('Try to fetch sap-btp-manager secret using binding from Kubernetes TokenRequest', async function() {
-    try {
-      await getSecret(secretName, ns);
-      fail('KCP must return an error');
-    } catch (err) {
-      console.log(err);
-    }
+    await expect(getSecret(secretName, ns)).to.be.rejectedWith(Error);
   });
 
   it('Create SKR binding using Gardener', async function() {
@@ -104,14 +94,7 @@ describe('SKR Binding test', function() {
   });
 
   it('Try to fetch SKR binding created using Gardener', async function() {
-    try {
-      await keb.getBinding(options.instanceID, bindingID);
-      fail('KEB must return an error');
-    } catch (err) {
-      expect(err.response.status).equal(404);
-      console.log('Got response:');
-      console.log(err.response.data);
-    }
+    await expect(keb.getBinding(options.instanceID, bindingID)).to.be.rejectedWith(Error);
   });
 
   it('Try to fetch sap-btp-manager secret using binding from Gardener', async function() {