Provisioner no longer registers runtime in the Compass Director, and creates the secret for Compass Runtime Agent #3399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…creates the secret for Compass Runtime Agent
koala7659
changed the title
kyma-bot
added
size/L
3 tasks
3 tasks
koala7659
changed the title
kyma-bot
removed
the
do-not-merge/work-in-progress
kyma-bot
added
size/XL
akgalwas
reviewed
Mar 7, 2024
| @@ -109,6 +109,11 @@ export APP_PROVISIONING_TIMEOUT_CLUSTER_CREATION=90m | |||
| export APP_PROVISIONING_NO_INSTALL_TIMEOUT_CLUSTER_CREATION=90m | |||
| export APP_PROVISIONING_TIMEOUT_UPGRADE_TRIGGERING=90m | |||
|
|
|||
| # for testing disabled Compass registration/deregistration | |||
| export APP_PROVISIONING_RUNTIME_REGISTRATION_ENABLED="false" | |||
There was a problem hiding this comment.
There are the following env variables:
APP_RUNTIME_REGISTRATION_ENABLEDAPP_RUNTIME_DEREGISTRATION_ENABLED
passed to the container. I can't whereAPP_PROVISIONING_RUNTIME_REGISTRATION_ENABLED, andAPP_PROVISIONING_RUNTIME_DEREGISTRATION_ENABLEDis used.
There was a problem hiding this comment.
Yes, it was from previous version. I will fix it
There was a problem hiding this comment.
E2E tests always fail anyway with success :)
| @@ -72,6 +72,33 @@ func TestStagesExecutor_Execute(t *testing.T) { | |||
| assert.True(t, mockStage.called) | |||
| }) | |||
|
|
|||
| t.Run("should not requeue operation when stage if Finished and Director integration is disabled", func(t *testing.T) { | |||
There was a problem hiding this comment.
if Finished -> is finished
akgalwas
previously approved these changes
Mar 8, 2024
|
/test pre-main-provisioner-e2e-tests |
|
/test all |
1 similar comment
|
/test all |
|
@koala7659: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
akgalwas
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #3088
Provisioner should no longer register runtime in the Compass Director, and create the secret for Compass Runtime Agent.
The feature is controlled with a two configuration flags to be able selectively disable old functionality on specific environment (DEV, STAGE, PROD)
KCP Overides:
compassIntegration.registratonEnabled,compassIntegration.deregistrationEnabledBoth flags are set to true by default.