Remove Compass integration code from the Provisioner

[akgalwas]

Description

Provisioner should no longer register runtime in the Compass Director, and create the secret for Compass Runtime Agent.

Reasons

Compass Manager will take over Compass integration responsibility. This issue is the last step of transition process.

Acceptance criteria

• Runtime registration functionality removed
• Code creating secret for the Compass Runtime Agent removed
• Provisioner returns information determining that runtime is not registered in Compass (Provisioner returns information determining whether runtime is registered in Compass #3085)

Proposal (by @koala7659 )
We can deliver this feature controlled with a configuration flag to selectively disable old functionality on specific environment (DEV, STAGE, PROD).

[kyma-bot]

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

• After 60d of inactivity, lifecycle/stale is applied
• After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

[tobiscr]

@akgalwas : has this to be done before we migrate the provisioner logic to the Infrastructure Manager or can we handle it together as part of kyma-project/infrastructure-manager#112 ?

[koala7659]

Some remarks for people who think about architecture of new control plane with compass-manager, Compass integration, and KIM (Kyma Infrastructure Manager)
I have just discovered some old code in Provisioner that marks current provisioning status of the Runtime in Director using RuntimeStatusCondition where possible states can be

const (
    RuntimeStatusConditionInitial      RuntimeStatusCondition = "INITIAL"
    RuntimeStatusConditionProvisioning RuntimeStatusCondition = "PROVISIONING"
    RuntimeStatusConditionConnected    RuntimeStatusCondition = "CONNECTED"
    RuntimeStatusConditionFailed       RuntimeStatusCondition = "FAILED"
)

We set such status during some operations with UpdateRuntime mutation.
As planned I'm disabling now (and in future will remove) all code that talks to Director in Provisioner.
Since we integration with Compass optional - only when user enables Application-connector module setting such status will not have any sense anymore.
This code cannot be migrated to compass-manager
I hope this will not make any braking change for the Compass Point of View.

[koala7659]

PR with implementation: #3399

[koala7659]

Test deployment on mps-dev: kcp-pg-provisioner

[koala7659]

@akgalwas Should we stop from now on returning CompassRuntimeID ?