Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transparent-proxy): add experimental tproxy iptables generation #4114

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

bartsmykla
Copy link
Contributor

Summary

This PR introduces experimental usage of new transparent proxy iptable rules generation, behind --experimental-transparent-proxy-engine flag of kumactl install transparent-proxy commannd

Full changelog

n/a

Issues resolved

n/a

Documentation

n/a

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

@bartsmykla bartsmykla requested a review from a team as a code owner April 4, 2022 11:54
@lahabana lahabana added this to the release-1. milestone Apr 4, 2022
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine but there's no helm chart update. We should favour doing changes to helm charts first especially now that: #4086 is merged and you can use --set everywhere,

@bartsmykla
Copy link
Contributor Author

This seems fine but there's no helm chart update. We should favour doing changes to helm charts first especially now that: #4086 is merged and you can use --set everywhere,

We currently are not configuring init containers at all using helm chart, which should be probably changed, but I would say we can do it as a followup

@bartsmykla bartsmykla merged commit 05227ad into kumahq:master Apr 5, 2022
@bartsmykla bartsmykla deleted the feat/experimental-tproxy branch April 5, 2022 10:09
@lahabana lahabana changed the title feat: add experimental tproxy iptables generation feat(transparent-proxy): add experimental tproxy iptables generation Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants