feat(kumactl): add --values and --set to kumactl install control-plane

[lahabana]

This makes kumactl a lot closer to what helm does which is the end is what we
use underneath.
We also add move validation to the helm chart so that we have this for
users of the helm chart too.

I believe that in future version we'd simply drop the old arguments but
let's keep it as is until docs and tests are updated to use this new method

Fix #1116

Signed-off-by: Charly Molter [email protected]

Testing

• Unit tests
• E2E tests
• [ ] Manual testing on Universal
• Manual testing on Kubernetes

Backwards compatibility

• Update UPGRADE.md with any steps users will need to take when upgrading.
• Add backport-to-stable label if the code follows our backporting policy

[codecov-commenter]

Codecov Report

Merging #4086 (75b6191) into master (4ccf576) will increase coverage by 0.05%.
The diff coverage is 64.81%.

@@            Coverage Diff             @@
##           master    #4086      +/-   ##
==========================================
+ Coverage   55.92%   55.98%   +0.05%     
==========================================
  Files         927      927              
  Lines       55562    55582      +20     
==========================================
+ Hits        31073    31116      +43     
+ Misses      22038    22016      -22     
+ Partials     2451     2450       -1     

Impacted Files	Coverage Δ
...d/install/context/install_control_plane_context.go	95.74% <ø> (ø)
app/kumactl/cmd/install/render_helm_files.go	90.90% <ø> (+3.90%)	⬆️
app/kumactl/cmd/install/install_control_plane.go	75.53% <64.81%> (-2.43%)	⬇️
pkg/config/core/config.go	50.00% <0.00%> (-50.00%)	⬇️
pkg/plugins/runtime/gateway/route/sorter.go	66.66% <0.00%> (-5.13%)	⬇️
pkg/core/resources/model/rest/resource.go	71.60% <0.00%> (-1.24%)	⬇️
pkg/plugins/resources/postgres/store.go	75.10% <0.00%> (+0.42%)	⬆️
pkg/xds/generator/direct_access_proxy_generator.go	90.80% <0.00%> (+1.14%)	⬆️
pkg/core/managers/apis/mesh/mesh_manager.go	49.38% <0.00%> (+2.46%)	⬆️
pkg/core/resources/manager/cache.go	85.71% <0.00%> (+2.59%)	⬆️
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ccf576...75b6191. Read the comment docs.

[jakubdyszkiewicz]

nice, I also like that we moved validation to HELM so it works with both deployment models