Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Increase timeout for coverage job #948

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

viccuad
Copy link
Member

@viccuad viccuad commented Oct 22, 2024

Description

This is in hopes of reducing tarpaulin time below 15 mins,
so it fits in GHA timeout.

Right now it times out after 15 mins:
https://github.com/kubewarden/kwctl/actions/runs/11442780601

Relates to #852.

Test

Tested locally, but cannot know about GHA timeout.

Additional Information

Tradeoff

Potential improvement

@viccuad viccuad self-assigned this Oct 22, 2024
@viccuad viccuad requested a review from a team as a code owner October 22, 2024 09:43
@flavio
Copy link
Member

flavio commented Oct 22, 2024

I'm fine with that, but I think we also realized we were running tarpaulin with some flags that made it slower than needed.

@fabriziosestito do you remember which project was fixed?

I see policy-server has some different options: https://github.com/kubewarden/policy-server/blob/9737ba8cfa17f578f6e6451f938611c98be8cbd8/Makefile#L46-L49

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.16%. Comparing base (a0c5b1f) to head (83058be).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #948   +/-   ##
=======================================
  Coverage   13.16%   13.16%           
=======================================
  Files          25       25           
  Lines        2036     2036           
=======================================
  Hits          268      268           
  Misses       1768     1768           
Flag Coverage Δ
unit-tests 13.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This is in hopes of reducing tarpaulin time below 15 mins,
so it fits in GHA timeout.

Signed-off-by: Víctor Cuadrado Juan <[email protected]>
@viccuad
Copy link
Member Author

viccuad commented Oct 22, 2024

Good point. I have force-pushed, removing the timeout increase and setting the same args as we use for policy-server instead.

@flavio
Copy link
Member

flavio commented Oct 22, 2024

It still got killed, maybe we have to raise the limit too, but to something higher than 30 minutes

@viccuad
Copy link
Member Author

viccuad commented Oct 22, 2024

Note that the CI run takes the code from main, not the PR though.

@viccuad viccuad merged commit 8dbf0cb into kubewarden:main Oct 22, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants