Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kwctl coverage and reach close to 70% #852

Closed
viccuad opened this issue Jul 4, 2024 · 1 comment · Fixed by #939
Closed

Fix kwctl coverage and reach close to 70% #852

viccuad opened this issue Jul 4, 2024 · 1 comment · Fixed by #939
Assignees
@jvanz
Labels
area/ci kind/tech-debt
Milestone
1.18

Comments

@viccuad
Copy link
Member

viccuad commented Jul 4, 2024

Acceptance criteria

In reality, we have ~65% code coverage already. Check why codecov coverage is not recognizing the tests.
Add the needed tests to reach ~70% coverage.
@viccuad viccuad changed the title Reach close to 70% on kwctl code coverage. Reach close to 70% on kwctl code coverage Jul 4, 2024
@viccuad viccuad changed the title Reach close to 70% on kwctl code coverage Fix kwctl coverage and reach close to 70% Jul 11, 2024
@flavio
Copy link
Member

flavio commented Oct 7, 2024

We need to fix the codecov configuration, I just checked and we have only 13% of code coverage which is wrong

@flavio flavio moved this to Todo in Kubewarden Oct 7, 2024
@flavio flavio added this to the 1.18 milestone Oct 7, 2024
@jvanz jvanz self-assigned this Oct 11, 2024
@jvanz jvanz moved this from Todo to In Progress in Kubewarden Oct 11, 2024
@jvanz jvanz mentioned this issue Oct 11, 2024
Merged
@jvanz jvanz moved this from In Progress to Pending review in Kubewarden Oct 11, 2024
@github-project-automation github-project-automation bot moved this from Pending review to Done in Kubewarden Oct 17, 2024
@viccuad viccuad mentioned this issue Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvanz jvanz

Labels
area/ci kind/tech-debt
Projects
Kubewarden
Archived in project
Milestone
1.18
Development

Successfully merging a pull request may close this issue.

Revert "ci: don't generate coverage for e2e tests" jvanz/kwctl
3 participants
@flavio @jvanz @viccuad