Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ci: don't generate coverage for e2e tests" #939

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

jvanz
Copy link
Member

@jvanz jvanz commented Oct 11, 2024

Description

This reverts commit bbe9ae3. As far as I can see we disable it during the issues with sigstore. Now, we can re enabled it! ;)

Fix #852

@jvanz jvanz self-assigned this Oct 11, 2024
@jvanz jvanz requested a review from a team as a code owner October 11, 2024 18:49
@jvanz jvanz added the kind/bug label Oct 11, 2024
This reverts commit bbe9ae3.

Signed-off-by: José Guilherme Vanz <[email protected]>
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.16%. Comparing base (f17ac15) to head (d8b5360).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #939   +/-   ##
=======================================
  Coverage   13.16%   13.16%           
=======================================
  Files          25       25           
  Lines        2036     2036           
=======================================
  Hits          268      268           
  Misses       1768     1768           
Flag Coverage Δ
unit-tests 13.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Víctor Cuadrado Juan <[email protected]>
@viccuad viccuad merged commit a0c5b1f into kubewarden:main Oct 17, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fix kwctl coverage and reach close to 70%
2 participants