-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce dependabot config #45
Conversation
|
||
version: 2 | ||
updates: | ||
- package-ecosystem: "gomod" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
target-branch: "main"
isn't missing here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, empty target-branch means deafult branch - in this case main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as in kubevirt/ssp-operator#744 (review)
82d33b0
to
91e06ef
Compare
.github/dependabot.yml
Outdated
interval: "daily" | ||
allow: | ||
- dependency-type: "all" | ||
reviewers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as on SSP: Do we need to set it at all? Won't kubevirt-bot assign one of the reviewers? IIRC I was assigned to previous PRs of dependabot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But e.g. I wasnt and I would like to know about the PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But won't this add all of the reviewers everytime? If you want to be notified about every PR on the repo, can't you subscribe to it individually instead?
this PR introduces dependabot config for main and other release branches. Signed-off-by: Karel Simon <[email protected]>
91e06ef
to
11af7d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
feat: introduce dependabot config
this PR introduces dependabot config for main and other release branches.
Release note: