-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce dependabot config #744
Conversation
|
||
version: 2 | ||
updates: | ||
- package-ecosystem: "gomod" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
target-branch: "main"
isn't missing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, empty target-branch means deafult branch - in this case main
/retest |
.github/dependabot.yml
Outdated
interval: "daily" | ||
allow: | ||
- dependency-type: "all" | ||
reviewers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it sync from OWNERS
file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find anything in documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to set it at all? Won't kubevirt-bot assign one of the reviewers? IIRC I was assigned to previous PRs of dependabot.
baa1d6f
to
794e4ef
Compare
this PR introduces dependabot config for main and other release branches. Signed-off-by: Karel Simon <[email protected]>
794e4ef
to
3370680
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
feat: introduce dependabot config
this PR introduces dependabot config for main and other release branches.
Release note: