deps: Split API into a sub-module and rename module to kubevirt.io/vm-console-proxy #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to be consistent with other kubevirt projects. Signed-off-by: Andrej Krejcir <[email protected]>
This will allow other projects to import the API definitions without importing all the dependencies of vm-console-proxy. Signed-off-by: Andrej Krejcir <[email protected]>
kubevirt-bot
added
release-note
|
Waiting for: kubevirt/kubevirt.github.io#962 /hold |
kubevirt-bot
added
the
do-not-merge/hold
|
The PR was merged. /unhold |
kubevirt-bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
codingben
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
I've asked Petr to merge kubevirt/kubevirt.github.io#962 because Daniel Hiller is OOO. This PR looks good to me, thanks Andrej.
/lgtm
/unhold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Changes in this PR:
kubevirt.io/vm-console-proxyto be consistent with other kubevirt projects.Release note: