Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add go-import for kubevirt.io/vm-console-proxy project #962

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Add go-import for kubevirt.io/vm-console-proxy project #962

merged 1 commit into from
Jul 31, 2024

Conversation

akrejcir
Copy link
Contributor

What this PR does / why we need it:
Added go module redirect for kubevirt.io/vm-console-proxy to be consistent with other kubevirt projects.

@akrejcir
Add go-import for kubevirt.io/vm-console-proxy project
2d4fef5 
Added go module redirect for kubevirt.io/vm-console-proxy
to be consistent with other kubevirt projects.

Signed-off-by: Andrej Krejcir <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Jul 30, 2024
@akrejcir
Copy link
Contributor Author

/cc @dhiller

@kubevirt-bot kubevirt-bot requested a review from dhiller July 30, 2024 08:33
@akrejcir akrejcir mentioned this pull request Jul 30, 2024
Merged
codingben
codingben approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@codingben codingben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2024
@codingben
Copy link
Member

codingben commented Jul 31, 2024 •
edited
Loading

@akrejcir Daniel Hiller is OOO for a couple of weeks. Someone else will need to approve it, I can see @stu-gott and @phoracek as approvers as well.

@phoracek
Copy link
Member

/approve

Looks good and in sync with the previous changes done to this file

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2024
@kubevirt-bot kubevirt-bot merged commit 15d1abf into kubevirt:main Jul 31, 2024
8 checks passed
@akrejcir akrejcir deleted the add-vm-proxy-redirect branch July 31, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingben codingben codingben approved these changes

@aburdenthehand aburdenthehand Awaiting requested review from aburdenthehand

@cwilkers cwilkers Awaiting requested review from cwilkers

@dhiller dhiller Awaiting requested review from dhiller

Assignees

@codingben codingben

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akrejcir @codingben @phoracek @kubevirt-bot