fix: Update Kubevirt CR used in CI #516
Conversation
kubevirt-bot
added
the
release-note-none
kubevirt-bot
added
the
dco-signoff: yes
|
/cc @0xFelix |
Enable "KubevirtSeccompProfile" feature gate, so VM can be started on OCP 4.13. Signed-off-by: Andrej Krejcir <[email protected]>
akrejcir
force-pushed
the
fix-ci-kubevirt
branch
from
cbcd1f0 to
19e5c5e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
/lgtm
Quick nit about the need for the LM feature gate but this LGTM in the short term.
Longer term I'd prefer it if we used the example CR provided with the release and patched in anything missing like this but that's something for a follow up so we can unblock 4.13 CI.
| kind: KubeVirt | ||
| metadata: | ||
| name: kubevirt | ||
| namespace: kubevirt | ||
| spec: | ||
| certificateRotateStrategy: {} | ||
| configuration: | ||
| selinuxLauncherType: "virt_launcher.process" | ||
| developerConfiguration: | ||
| featureGates: | ||
| - DataVolumes | ||
| - CPUManager | ||
| - LiveMigration |
There was a problem hiding this comment.
nit - Do we really need LiveMigration?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
What this PR does / why we need it:
Enable
KubevirtSeccompProfilefeature gate, so VM can be started on OCP 4.13.Release note: