Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use example CR provided by kubevirt #517

Closed
0xFelix opened this issue Mar 10, 2023 · 1 comment
Closed

Use example CR provided by kubevirt #517

0xFelix opened this issue Mar 10, 2023 · 1 comment
Assignees
@akrejcir
Labels
kind/enhancement

Comments

@0xFelix
Copy link
Member

0xFelix commented Mar 10, 2023

/kind enhancement

What happened:

The CI tests use a hardcoded kubevirt CR with some additional required feature flags added.

It would be nice if the test were using the example CR provided with the latest kubevirt release and were patching in any missing required feature flags instead of using a hardcoded kubevirt CR.

This will help to avoid situations like #516, where deprecated values in the CR cause issues.

See:
@akrejcir akrejcir mentioned this issue Mar 14, 2023
Merged
@akrejcir
Copy link
Collaborator

The PR was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akrejcir akrejcir

Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@0xFelix @akrejcir @kubevirt-bot