Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add usb emulation for 1.25 #2922

Closed
wants to merge 1 commit into from
Closed

Add usb emulation for 1.25 #2922

wants to merge 1 commit into from

Conversation

victortoso
Copy link
Member

@victortoso victortoso commented Aug 8, 2023 •
edited
Loading

Hi,

I don't remember why we have not added this in #2872 so I'm starting this thread with a PR :)
Functional tests with 1.26 and 1.27 worked great!

Cheers,

@victortoso
Add usb emulation for 1.25
a46ce91 
We have added for sig-compute 1.26 and 1.27:
    kubevirt#2872

Signed-off-by: Victor Toso <[email protected]>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Aug 8, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rmohr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot requested review from alicefr and EdDev August 8, 2023 09:14
brianmcarey
brianmcarey reviewed Aug 8, 2023
View reviewed changes
Copy link
Member

@brianmcarey brianmcarey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe support for this was not added to the centos stream 8 based providers (so just 1.25) - it was just added to the centos stream 9 providers[1]

With 1.28 around the corner it may not be worth adding to the stream 8 provider.

@xpivarc - what do you think?

[1] kubevirt/kubevirtci#996

@xpivarc
Copy link
Member

xpivarc commented Aug 8, 2023

@brianmcarey
Might as well be true :)

@victortoso
Copy link
Member Author

I believe support for this was not added to the centos stream 8 based providers (so just 1.25) - it was just added to the centos stream 9 providers[1]

Aha. 1.25 is c8s based.

With 1.28 around the corner it may not be worth adding to the stream 8 provider.

No problem at all. I'll update the PR to skip 1.25 later. Thanks for the quick review!

@victortoso victortoso closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcarey brianmcarey brianmcarey left review comments

@alicefr alicefr Awaiting requested review from alicefr

@EdDev EdDev Awaiting requested review from EdDev

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victortoso @kubevirt-bot @xpivarc @brianmcarey