Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add usb emulation for hostdev testing #2872

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Add usb emulation for hostdev testing #2872

merged 1 commit into from
Jul 11, 2023

Conversation

victortoso
Copy link
Member

This is possible since:
kubevirt/kubevirtci#996

The follow CI would benefit from it:
kubevirt/kubevirt#10015

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jul 6, 2023
@kubevirt-bot kubevirt-bot requested review from lyarwood and stu-gott July 6, 2023 11:03
@brianmcarey
Copy link
Member

/rehearse ?

@kubevirt-bot
Copy link
Contributor

Rehearsal is available for the following jobs in this PR:

pull-kubevirt-e2e-k8s-1.26-sig-compute

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@brianmcarey
Copy link
Member

/rehearse pull-kubevirt-e2e-k8s-1.26-sig-compute

/cc

@kubevirt-bot kubevirt-bot requested a review from brianmcarey July 6, 2023 11:25
@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.26-sig-compute

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@victortoso victortoso force-pushed the c9s-enable-usb-emulation branch from 096c4ce to 01bc9ad Compare July 6, 2023 11:43
@brianmcarey
Copy link
Member

/rehearse

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.27-sig-compute
rehearsal-pull-kubevirt-e2e-k8s-1.26-sig-compute

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@victortoso
Copy link
Member Author

/retest-required

@victortoso
Copy link
Member Author 

14:31:09:   [FAILED] Timed out after 95.106s.
14:31:09:   Expected
14:31:09:       <string>: virt-controller-bf5b79f8d-tm2cz
14:31:09:   to equal
14:31:09:       <string>: virt-controller-bf5b79f8d-7c68f
14:31:09:   In [It] at: tests/infra_test.go:1203 @ 07/06/23 14:31:01.739
14:31:09: 
14:31:09:   Full Stack Trace
14:31:09:     kubevirt.io/kubevirt/tests_test.glob..func9.11.1.1()
14:31:09:     	tests/infra_test.go:1203 +0x1e2

/rehearse rehearsal-pull-kubevirt-e2e-k8s-1.27-sig-compute

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@brianmcarey
Copy link
Member

/rehearse

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.26-sig-compute
rehearsal-pull-kubevirt-e2e-k8s-1.27-sig-compute

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@brianmcarey
Copy link
Member

/cc @xpivarc

I don't see any usb disks created in the rehearsal job logs - are we missing something here?

@kubevirt-bot kubevirt-bot requested a review from xpivarc July 7, 2023 10:39
@victortoso victortoso mentioned this pull request Jul 10, 2023
Merged
@victortoso
Add usb emulation for hostdev testing
7468498 
For sig-compute in 1.26 and 1.27 only.

This is possible since:
  kubevirt/kubevirtci#996

The follow CI would benefit from it:
  kubevirt/kubevirt#10015

Signed-off-by: Victor Toso <[email protected]>
@victortoso victortoso force-pushed the c9s-enable-usb-emulation branch from 01bc9ad to 7468498 Compare July 10, 2023 10:14
@xpivarc
Copy link
Member

xpivarc commented Jul 10, 2023

/rehearse ?
I could successfully run it with the main but used a newer image. Let me fallback to one used by these jobs

@kubevirt-bot
Copy link
Contributor

Rehearsal is available for the following jobs in this PR:

pull-kubevirt-e2e-k8s-1.26-sig-compute
pull-kubevirt-e2e-k8s-1.27-sig-compute

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@xpivarc
Copy link
Member

xpivarc commented Jul 10, 2023

/rehearse pull-kubevirt-e2e-k8s-1.26-sig-compute

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.26-sig-compute

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@victortoso
Copy link
Member Author

/rehearse pull-kubevirt-e2e-k8s-1.26-sig-compute

 13:03:38:   [FAILED] Timed out after 95.094s.
13:03:38:   Expected
13:03:38:       <string>: virt-controller-57c5745bc5-qnfjb
13:03:38:   to equal
13:03:38:       <string>: virt-controller-57c5745bc5-g2ff9
13:03:38:   In [It] at: tests/infra_test.go:1203 @ 07/10/23 13:03:30.055
13:03:38: 
13:03:38:   Full Stack Trace
13:03:38:     kubevirt.io/kubevirt/tests_test.glob..func9.11.1.1()
13:03:38:     	tests/infra_test.go:1203 +0x1e2
13:03:38: ------------------------------
14:05:58: ••••••••••••••SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•SSSSSSSSSSSSSS•SSSSSSSSSSSSSSSSSSSSSSS•••••••SS••••••••••SSSSSSSSSSSSSS••S••SSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•••••••••S•SS••SSSSSSSSSSSSSSS•S••SSSSSS••SSSSSSSSSS•S•SSSS••••SSS•••SSSSSSSS•••SS••••••••••••SSSS•SSSSS••••••••SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS••SSSSSSS•SS•SSSSS•SSSSSSSSSSSSSSSSSSSSSSSSSSS•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS••SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS••SS••SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
14:05:58: Waiting for namespace kubevirt-test-default1 to be removed, this can take a while ...
14:06:04: Waiting for namespace kubevirt-test-alternative1 to be removed, this can take a while ...
14:06:04: Waiting for namespace kubevirt-test-operator1 to be removed, this can take a while ...
14:06:04: Waiting for namespace

Same timeout from comment above

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.26-sig-compute

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@victortoso
Copy link
Member Author

/rehearse pull-kubevirt-e2e-k8s-1.26-sig-compute

15:19:15: 15:19:15: WARNING: Download from https://mirror.bazel.build/openjdk/azul-zulu11.50.19-ca-jdk11.0.12/zulu11.50.19-ca-jdk11.0.12-linux_x64.tar.gz failed: class com.google.devtools.build.lib.bazel.repository.downloader.ContentLengthMismatchException Bytes read 74710480 but wanted 202599005
15:19:15: 15:19:15: ERROR: An error occurred during the fetch of repository 'remotejdk11_linux':
15:19:15: 15:19:15:    Traceback (most recent call last): 
...
15:19:15: 15:19:15: Error in download_and_extract: java.io.IOException: Error downloading [https://mirror.bazel.build/openjdk/azul-zulu11.50.19-ca-jdk11.0.12/zulu11.50.19-ca-jdk11.0.12-linux_x64.tar.gz] to /tmp/cache/bazel/18316b1300bb8985bc913139d5cc6323/external/remotejdk11_linux/temp8656814839194484506/zulu11.50.19-ca-jdk11.0.12-linux_x64.tar.gz: Bytes read 74710480 but wanted 202599005
15:19:15: 15:19:15: ERROR: /tmp/cache/bazel/18316b1300bb8985bc913139d5cc6323/external/bazel_tools/tools/jdk/BUILD:29:19: @bazel_tools//tools/jdk:current_java_runtime depends on @remotejdk11_linux//:jdk in repository @remotejdk11_linux which failed to fetch. no such package '@remotejdk11_linux//': java.io.IOException: Error downloading [https://mirror.bazel.build/openjdk/azul-zulu11.50.19-ca-jdk11.0.12/zulu11.50.19-ca-jdk11.0.12-linux_x64.tar.gz] to /tmp/cache/bazel/18316b1300bb8985bc913139d5cc6323/external/remotejdk11_linux/temp8656814839194484506/zulu11.50.19-ca-jdk11.0.12-linux_x64.tar.gz: Bytes read 74710480 but wanted 202599005
15:19:15: 15:19:15: ERROR: Analysis of target '//tests:go_default_test' failed; build aborted: 
15:19:15: 15:19:15: INFO: Elapsed time: 7.107s

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.26-sig-compute

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@xpivarc
Copy link
Member

xpivarc commented Jul 11, 2023

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
brianmcarey
brianmcarey approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@kubevirt-bot kubevirt-bot merged commit a1ca142 into kubevirt:main Jul 11, 2023
@kubevirt-bot
Copy link
Contributor

@victortoso: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key kubevirt-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits.yaml

In response to this:

This is possible since:
kubevirt/kubevirtci#996

The follow CI would benefit from it:
kubevirt/kubevirt#10015

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

victortoso added a commit to victortoso/project-infra that referenced this pull request Aug 8, 2023
@victortoso
Add usb emulation for 1.25
a46ce91 
We have added for sig-compute 1.26 and 1.27:
    kubevirt#2872

Signed-off-by: Victor Toso <[email protected]>
@victortoso victortoso mentioned this pull request Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xpivarc xpivarc xpivarc left review comments

@brianmcarey brianmcarey brianmcarey approved these changes

@lyarwood lyarwood Awaiting requested review from lyarwood

@stu-gott stu-gott Awaiting requested review from stu-gott

Assignees

@brianmcarey brianmcarey

@xpivarc xpivarc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victortoso @brianmcarey @kubevirt-bot @xpivarc