Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.12.2 #130

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Release v0.12.2 #130

merged 1 commit into from
Jan 9, 2025

Conversation

maiqueb
Copy link
Collaborator

@maiqueb maiqueb commented Dec 17, 2024

What this PR does / why we need it:
New patch release

Special notes for your reviewer:
We're skipping v0.12.1 because I have messed up the previous release, and while intending to release v0.12.0 I actually left a leftover in version/version.go pointing at v0.12.1 .

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 17, 2024
@kubevirt-bot kubevirt-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S labels Dec 17, 2024
@maiqueb maiqueb mentioned this pull request Dec 17, 2024
Merged
oshoval
oshoval reviewed Dec 22, 2024
View reviewed changes
@ashokpariya0 ashokpariya0 mentioned this pull request Jan 6, 2025
Closed
@maiqueb
Release v0.12.2
bd95041 
Signed-off-by: Miguel Duarte Barroso <[email protected]>
@maiqueb
Copy link
Collaborator Author

maiqueb commented Jan 9, 2025

@oshoval please review.

oshoval
oshoval approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maiqueb, oshoval

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maiqueb
Copy link
Collaborator Author

maiqueb commented Jan 9, 2025

Thanks !

@oshoval can you /lgtm the PR ?... I really don't understand this bot ...

@oshoval
Copy link
Contributor

oshoval commented Jan 9, 2025

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2025
@oshoval
Copy link
Contributor

oshoval commented Jan 9, 2025

need prow config on project-infra for lgtm maybe i case missing

@kubevirt-bot kubevirt-bot merged commit 28f533d into kubevirt:main Jan 9, 2025
5 checks passed
@oshoval
Copy link
Contributor

oshoval commented Jan 9, 2025

The post submit jobs (would be nice if prow was auto pasting it, at least for releases or so)
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/release-macvtap-cni/1877369936662237184
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/publish-macvtap-cni/1877369936523825152

@maiqueb maiqueb deleted the release-v0.12.2 branch January 9, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokpariya0 ashokpariya0 ashokpariya0 left review comments

@oshoval oshoval oshoval approved these changes

@phoracek phoracek Awaiting requested review from phoracek

Assignees

@oshoval oshoval

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maiqueb @kubevirt-bot @oshoval @ashokpariya0