-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Construct the image name directly within the build target #129
Conversation
Hi @ashokpariya0. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cc @oshoval |
Pass IMAGE_TAG to the build targets to ensure the correct image tag is used. Set the PLATFORMS variable to all in the release.sh script to automatically build for all supported platforms. Update install-go.sh to select the appropriate Go tarball based on the host architecture Signed-off-by: Ashok Pariya [email protected]
96ca776
to
c3951cd
Compare
/ok-to-test |
Thanks iiuc the reason for the tag fix, is that under release target it calculate the value of the tag ? /lgtm |
Done |
Please remove this from PR desc
as it repeats |
sgtm, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashokpariya0, maiqueb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@maiqueb Could you please create a new release tag so that we can use it in CNAO ? |
What this PR does / why we need it:
It sets the PLATFORMS variable to all in the release.sh script, enabling automatic image builds for all supported platforms.
The
IMAGE_TAG
runs in a local scope when using themake release
command, so we don't need to prepare the full name in advance. Instead, we can generate it locally within the targets based on the value passed.Additionally, it updates install-go.sh to select the appropriate Go tarball based on the system's architecture.
Special notes for your reviewer:
Release note: