Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct the image name directly within the build target #129

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

ashokpariya0
Copy link
Contributor

@ashokpariya0 ashokpariya0 commented Dec 12, 2024

What this PR does / why we need it:
It sets the PLATFORMS variable to all in the release.sh script, enabling automatic image builds for all supported platforms.

The IMAGE_TAG runs in a local scope when using the make release command, so we don't need to prepare the full name in advance. Instead, we can generate it locally within the targets based on the value passed.

Additionally, it updates install-go.sh to select the appropriate Go tarball based on the system's architecture.

Special notes for your reviewer:

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 12, 2024
@kubevirt-bot kubevirt-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 12, 2024
@kubevirt-bot
Copy link
Collaborator

Hi @ashokpariya0. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ashokpariya0
Copy link
Contributor Author

cc @oshoval

@ashokpariya0 ashokpariya0 mentioned this pull request Dec 12, 2024
Pass IMAGE_TAG to the build targets to ensure the correct image tag is used.
Set the PLATFORMS variable to all in the release.sh script to automatically
build for all supported platforms. Update install-go.sh to select the appropriate
Go tarball based on the host architecture

Signed-off-by: Ashok Pariya [email protected]
@maiqueb
Copy link
Collaborator

maiqueb commented Dec 13, 2024

/ok-to-test

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 13, 2024
@oshoval
Copy link
Contributor

oshoval commented Dec 15, 2024

Thanks
PR desc: Please remove the first half, as the 2nd one (under "What this PR does / why we need it") repeats it.
Please use new lines to ease reading.

iiuc the reason for the tag fix, is that under release target it calculate the value of the tag ?
please consider adding the explanation to PR desc please in few words

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2024
@ashokpariya0
Copy link
Contributor Author

Thanks PR desc: Please remove the first half, as the 2nd one (under "What this PR does / why we need it") repeats it. Please use new lines to ease reading.

iiuc the reason for the tag fix, is that under release target it calculate the value of the tag ? please consider adding the explanation to PR desc please in few words

/lgtm

Done

@oshoval
Copy link
Contributor

oshoval commented Dec 15, 2024

Please remove this from PR desc

Pass IMAGE_TAG to the build targets to ensure the correct image tag is used. Set the PLATFORMS variable to all in the release.sh script to automatically build for all supported platforms. Update install-go.sh to select the appropriate Go tarball based on the host architecture

Signed-off-by: Ashok Pariya [[email protected]](mailto:[email protected])

as it repeats
Thanks

@ashokpariya0
Copy link
Contributor Author

@maiqueb @oshoval Just wanted to let you know that the tests have passed for this PR. Can we proceed with the PR and create new release for CNAO to consume?

@oshoval
Copy link
Contributor

oshoval commented Dec 16, 2024

sgtm, thanks

Copy link
Collaborator

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashokpariya0, maiqueb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@kubevirt-bot kubevirt-bot merged commit 4fbcfed into kubevirt:main Dec 16, 2024
5 checks passed
@ashokpariya0
Copy link
Contributor Author

@maiqueb Could you please create a new release tag so that we can use it in CNAO ?

@maiqueb
Copy link
Collaborator

maiqueb commented Dec 17, 2024

@ashokpariya0 #130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants