Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WFFC variation of rook-ceph-block #967

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Add WFFC variation of rook-ceph-block #967

merged 1 commit into from
Feb 21, 2023

Conversation

akalenyu
Copy link
Contributor

We might want to test WFFC fancy storage sometime instead of just immediate binding ones

@akalenyu
Add WFFC variation of rook-ceph-block
88de4cf 
We might want to test WFFC fancy storage sometime instead of just immediate binding ones

Signed-off-by: Alex Kalenyuk <[email protected]>
@kubevirt-bot kubevirt-bot requested a review from dhiller February 20, 2023 16:03
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Feb 20, 2023
@akalenyu
Copy link
Contributor Author

/cc @ShellyKa13 @awels
This way we could test wffc fancy storage and possibly stop using "local" as well

ShellyKa13
ShellyKa13 reviewed Feb 21, 2023
View reviewed changes
Copy link

@ShellyKa13 ShellyKa13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
sounds good!

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023
@awels
Copy link
Member

awels commented Feb 21, 2023

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2023
@kubevirt-bot kubevirt-bot merged commit bc50e16 into kubevirt:main Feb 21, 2023
oshoval added a commit to oshoval/kubevirt that referenced this pull request Mar 6, 2023
@oshoval
Bump kubevirtci
b3e7d18 
[1b9174d centos8: update SELinux policy version](kubevirt/kubevirtci#975)
[e1cf770 robust stack: Fix sanity check](kubevirt/kubevirtci#970)
[bc50e16 Add WFFC variation of rook-ceph-block](kubevirt/kubevirtci#967)
[656d01a centos8: set SELinux boolean that is now required for chardev access by containers](kubevirt/kubevirtci#968)
[31e5860 vm based providers: Introduce robust stack provider](kubevirt/kubevirtci#954)
[15b2c14 Refresh snapshot CRDs follow up for 1.26-centos9 provider](kubevirt/kubevirtci#947)
[0163752 Enable Seccomp configuration](kubevirt/kubevirtci#960)
[e037eb1 Adds note about CLI dependencies](kubevirt/kubevirtci#959)
[9c37b86 k8s-1.24-psa: Remove leftovers](kubevirt/kubevirtci#956)

```release-note
NONE
```

Signed-off-by: Or Shoval <[email protected]>
@oshoval oshoval mentioned this pull request Mar 6, 2023
Merged
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Mar 6, 2023
@kubevirt-bot
Bump kubevirtci
fb63515 
[1b9174d centos8: update SELinux policy version](kubevirt/kubevirtci#975)
[e1cf770 robust stack: Fix sanity check](kubevirt/kubevirtci#970)
[bc50e16 Add WFFC variation of rook-ceph-block](kubevirt/kubevirtci#967)
[656d01a centos8: set SELinux boolean that is now required for chardev access by containers](kubevirt/kubevirtci#968)
[31e5860 vm based providers: Introduce robust stack provider](kubevirt/kubevirtci#954)
[15b2c14 Refresh snapshot CRDs follow up for 1.26-centos9 provider](kubevirt/kubevirtci#947)
[0163752 Enable Seccomp configuration](kubevirt/kubevirtci#960)
[e037eb1 Adds note about CLI dependencies](kubevirt/kubevirtci#959)
[9c37b86 k8s-1.24-psa: Remove leftovers](kubevirt/kubevirtci#956)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
@kubevirt-bot kubevirt-bot mentioned this pull request Mar 6, 2023
Closed
@jean-edouard jean-edouard mentioned this pull request Mar 6, 2023
Closed
oshoval added a commit to oshoval/kubevirt that referenced this pull request Mar 7, 2023
@oshoval
Bump kubevirtci
3cafa2f 
[1b9174d centos8: update SELinux policy version](kubevirt/kubevirtci#975)
[e1cf770 robust stack: Fix sanity check](kubevirt/kubevirtci#970)
[bc50e16 Add WFFC variation of rook-ceph-block](kubevirt/kubevirtci#967)
[656d01a centos8: set SELinux boolean that is now required for chardev access by containers](kubevirt/kubevirtci#968)
[31e5860 vm based providers: Introduce robust stack provider](kubevirt/kubevirtci#954)
[15b2c14 Refresh snapshot CRDs follow up for 1.26-centos9 provider](kubevirt/kubevirtci#947)
[0163752 Enable Seccomp configuration](kubevirt/kubevirtci#960)
[e037eb1 Adds note about CLI dependencies](kubevirt/kubevirtci#959)
[9c37b86 k8s-1.24-psa: Remove leftovers](kubevirt/kubevirtci#956)

```release-note
NONE
```

Signed-off-by: Or Shoval <[email protected]>
oshoval added a commit to oshoval/kubevirt that referenced this pull request Mar 7, 2023
@oshoval
Bump kubevirtci
0a790cd 
[1b9174d centos8: update SELinux policy version](kubevirt/kubevirtci#975)
[e1cf770 robust stack: Fix sanity check](kubevirt/kubevirtci#970)
[bc50e16 Add WFFC variation of rook-ceph-block](kubevirt/kubevirtci#967)
[656d01a centos8: set SELinux boolean that is now required for chardev access by containers](kubevirt/kubevirtci#968)
[31e5860 vm based providers: Introduce robust stack provider](kubevirt/kubevirtci#954)
[15b2c14 Refresh snapshot CRDs follow up for 1.26-centos9 provider](kubevirt/kubevirtci#947)
[0163752 Enable Seccomp configuration](kubevirt/kubevirtci#960)
[e037eb1 Adds note about CLI dependencies](kubevirt/kubevirtci#959)
[9c37b86 k8s-1.24-psa: Remove leftovers](kubevirt/kubevirtci#956)

```release-note
NONE
```

Signed-off-by: Or Shoval <[email protected]>
@akalenyu akalenyu mentioned this pull request Mar 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShellyKa13 ShellyKa13 ShellyKa13 left review comments

@dhiller dhiller Awaiting requested review from dhiller

@jean-edouard jean-edouard Awaiting requested review from jean-edouard

@awels awels Awaiting requested review from awels

Assignees

@ShellyKa13 ShellyKa13

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akalenyu @awels @kubevirt-bot @ShellyKa13