Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ceph WFFC lane set up #2644

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Ceph WFFC lane set up #2644

merged 3 commits into from
Apr 6, 2023

Conversation

akalenyu
Copy link
Collaborator

@akalenyu akalenyu commented Mar 16, 2023 •
edited
Loading

What this PR does / why we need it:
We aim to support WFFC storage classes seamlessly so a periodic run from time to time may
increase our confidence in such setup

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
kubevirtci now gives us both an Immediate & WFFC storage class kubevirt/kubevirtci#967

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL labels Mar 16, 2023
@kubevirt-bot kubevirt-bot requested review from awels and oshoval March 16, 2023 16:43
@akalenyu
Copy link
Collaborator Author

/cc @awels sonar cloud complains about cluster-up but I am pretty sure we have excluded it before

@kubevirt-bot
Copy link
Contributor

@akalenyu: GitHub didn't allow me to request PR reviews from the following users: am, pretty, excluded, before, sonar, sure, it, but, I, we, have, complains.

Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @awels sonar cloud complains about cluster-up but I am pretty sure we have excluded it before

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awels
awels reviewed Mar 24, 2023
View reviewed changes
Copy link
Member

@awels awels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
looks good to me, just one random question.

automation/ceph-wffc.sh
#

set -ex
export TARGET=k8s-1.24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to use 1.25?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, just sticking close to the current ceph script

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2023
oshoval
oshoval reviewed Mar 26, 2023
View reviewed changes
cluster-sync/k8s-1.23/provider.sh Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.23 is not supported anymore

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed together with 1.22

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm in this aspect, thanks

@akalenyu
Copy link
Collaborator Author

akalenyu commented Apr 3, 2023

/cc @awels Sonar complaining again :(

@awels
Copy link
Member

awels commented Apr 3, 2023

Fixed it again, even though we told it to exclude /cluster-up it is still checking.

@akalenyu
Copy link
Collaborator Author

akalenyu commented Apr 3, 2023

Fixed it again, even though we told it to exclude /cluster-up it is still checking.

Also lost your lgtm, basically didn't change anything other than removing some outdated sync providers

@awels
Copy link
Member

awels commented Apr 6, 2023

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2023
@kubevirt-bot kubevirt-bot merged commit 6bb139e into kubevirt:main Apr 6, 2023
akalenyu added a commit to akalenyu/containerized-data-importer that referenced this pull request Jul 27, 2023
@akalenyu
Ceph WFFC lane set up (kubevirt#2644)
ff5cfee 
* Bump kubevirtci for wffc ceph storage class

Signed-off-by: Alex Kalenyuk <[email protected]>

* Add infrastructure needed for ceph wffc lane

Signed-off-by: Alex Kalenyuk <[email protected]>

* Remove unused cluster sync providers

Signed-off-by: Alex Kalenyuk <[email protected]>

---------

Signed-off-by: Alex Kalenyuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshoval oshoval oshoval left review comments

@awels awels awels left review comments

Assignees

@awels awels

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akalenyu @kubevirt-bot @awels @oshoval