whereabouts: bump to v0.5.4 #847
Conversation
kubevirt-bot
added
the
dco-signoff: yes
|
Added a commit to switch to Fedora 36 for building the Centos 8 image (oO). |
There was a problem hiding this comment.
Thanks, nice
Can you please update PR desc about the reason as appears here?
kubevirt/kubevirt#7168 (comment)
Also if you can update PR desc about pinning to fedora:36 because the hash doesn't work
| @@ -6,6 +6,3 @@ resources: | |||
| - ./daemonset-install.yaml | |||
| - ./whereabouts.cni.cncf.io_ippools.yaml | |||
| - ./whereabouts.cni.cncf.io_overlappingrangeipreservations.yaml | |||
|
|
|||
| transformers: | |||
There was a problem hiding this comment.
I think that the files appear above are deleted as well ?
(they were merged into the current file)
also once there isn't a transformers we basically not need this file and the references of it
On the other hand, we will need on a follow PR to use kustomize again in order to pin the version
until k8snetworkplumbingwg/whereabouts#252 is fixed
(unless it is already fixed for 0.5.4)
kubevirt-bot
added
the
do-not-merge/work-in-progress
jean-edouard
force-pushed
the
whereabouts54
branch
from
775c024
to
ba867e9
Compare
kubevirt-bot
removed
the
do-not-merge/work-in-progress
|
Removed the fedora fix commit, as it was addressed by another (already merged) PR. |
| @@ -7,5 +7,16 @@ resources: | |||
| - ./whereabouts.cni.cncf.io_ippools.yaml | |||
| - ./whereabouts.cni.cncf.io_overlappingrangeipreservations.yaml | |||
|
|
|||
| transformers: | |||
| - patch-ip-reconciler-job.yaml | |||
| patches: | |||
There was a problem hiding this comment.
Thanks for the changes
Can it be done please with this kustomization style ?
https://github.com/kubevirt/kubevirtci/blob/main/cluster-up/cluster/kind-1.22-sriov/sriov-components/manifests/kustomization.yaml#L9
and then the sed in the script is not needed
There was a problem hiding this comment.
How do you pass the version number to kustomize without using sed?
There was a problem hiding this comment.
newTag i think ? (just have the version hardcoded in it)
something like this (newName is not needed)
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- grafana-deployment.yaml
images:
- name: grafana/grafana
newName: quay.io/kubevirtci/grafana-grafana
newTag: <TAG>
There was a problem hiding this comment.
And.. how do you set <TAG>? :)
There was a problem hiding this comment.
envsubst / sed it according "whereabouts_version", wdyt?
|
Please also update the manifest of k8s-1.24-ipv6 and if you can update please the PR desc with the reasoning as you found here |
|
Hi @maiqueb Then we won't need to kustomize it ourself |
jean-edouard
force-pushed
the
whereabouts54
branch
2 times, most recently
from
1df643a
to
4965825
Compare
v0.5.4 is using a pinned version. ... might be a bit confusing to use the generated version for v0.5.3, but, it is pinned. Going forward, we'll try to make sure we don't screw up again. |
I am lost a bit tbh |
I don't follow what is it you don't understand; you asked me to pin whereabouts v0.5.4, and I've replied: it is already pinned - check the commit to which the whereabouts repo v0.5.4 release is pointing to. |
Signed-off-by: Jed Lejosne <[email protected]>
jean-edouard
force-pushed
the
whereabouts54
branch
from
4965825
to
6f3e155
Compare
I expect that users of the repo should not have to pin a version like this PR is doing |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enp0s3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/retest-required |
|
/hold need to cordon PR to be merged first, so lanes will pass |
kubevirt-bot
added
the
do-not-merge/hold
|
/test check-provision-k8s-1.23 |
|
I think we are good we can remove the hold imo |
|
/unhold /retest |
kubevirt-bot
removed
the
do-not-merge/hold
[3b5306b whereabouts: bump to v0.5.4](kubevirt/kubevirtci#847) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
We're currently using v0.5, which appears to be unreliable, probably due to the race condition issues they've been working on upstream.
v0.5.4 should contain all the necessary fixes.