Update cluster provisioning image to fedora 36 #799

brianmcarey · 2022-05-23T14:52:14Z

Fedora 31 is no longer supported so we should update to use Fedora 36.
This change also includes a bump to the dockerize version to the latest
release.

Signed-off-by: Brian Carey [email protected]

Fedora 31 is no longer supported so we should update to use Fedora 36. This change also includes a bump to the dockerize version to the latest release. Signed-off-by: Brian Carey <[email protected]>

kubevirt-bot · 2022-05-23T14:52:16Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

brianmcarey · 2022-05-23T14:52:44Z

/test check-provision-k8s-1.23

brianmcarey · 2022-05-31T12:54:08Z

/test check-provision-k8s-1.23

brianmcarey · 2022-06-01T07:16:23Z

/retest-required

dankenigsberg · 2022-06-02T09:44:43Z

cluster-provision/centos8/scripts/vm.sh

@@ -150,6 +150,6 @@ exec qemu-system-x86_64 -enable-kvm -drive format=qcow2,file=${next},if=virtio,c
  -append "$(cat /kernel.args) $(cat /additional.kernel.args) ${KERNEL_ARGS}" \
  -vnc :${n} -cpu host,migratable=no,+invtsc -m ${MEMORY} -smp ${CPU} \
  -serial pty -M q35,accel=kvm,kernel_irqchip=split \
-  -device intel-iommu,intremap=on,caching-mode=on -soundhw hda -soundhw ac97 \
+  -device intel-iommu,intremap=on,caching-mode=on -device intel-hda -device hda-duplex -device AC97 \


now that -shoundhw is gone, -device AC97 is more opaque; but why do we need audio on kubernetes nodes? Can it be dropped (on another PR?)

Sorry I removed these too soon - soundhw is only removed qemu 7.1[1]. Fedora 36 has qemu 6.2. I have added the soundhw flags back in as they are more descriptive of what the device is. These soundcards are used for testing scenarios with the Kubevirt device plugin - #734

[1] https://github.com/qemu/qemu/blob/master/docs/about/removed-features.rst#creating-sound-card-devices-using--soundhw-removed-in-71

Just note please that we do have this warning

qemu-system-x86_64: warning: '-soundhw ac97' is deprecated, please use '-device AC97' instead qemu-system-x86_64: warning: '-soundhw hda' is deprecated, please use '-device intel-hda -device hda-duplex' instead

This should remove those warnings:
#828

The backing file format is required since qemu v6.1[1] [1] https://github.com/qemu/qemu/blob/master/docs/about/removed-features.rst#qemu-img-backing-file-without-format-removed-in-61 Signed-off-by: Brian Carey <[email protected]>

The manifest directories have to be in place before carrying out the copy with scp. If the directories are not in place, the scp command will fail due to not being able to find the directories. Signed-off-by: Brian Carey <[email protected]>

brianmcarey · 2022-06-03T07:06:48Z

/test check-provision-k8s-1.23

brianmcarey · 2022-06-08T13:04:56Z

/test check-provision-k8s-1.24

dhiller · 2022-06-08T13:53:47Z

@brianmcarey looks like we at are beyond capacity again, thus the job doesn't get started...

cluster-provision/centos8/Dockerfile

dhiller

/approve
/hold

Unhold whenever it suits best.

kubevirt-bot · 2022-06-14T14:53:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dhiller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

brianmcarey · 2022-06-20T08:00:25Z

/unhold

oshoval · 2022-06-20T08:02:41Z

cluster-provision/centos8/Dockerfile


 ARG centos_version

-RUN dnf -y update nettle && dnf -y install jq iptables iproute dnsmasq qemu openssh-clients screen && dnf clean all
+RUN dnf -y install jq iptables iproute dnsmasq qemu openssh-clients screen && dnf clean all


Can you explain why nettle is not required ?
(in PR desc / commit preferably if possible please)

Ah its update, maybe the shipped version is good enough ?

Yes - when I was running this - the dnf update was not actually updating anything - nothing to update.

brianmcarey · 2022-06-29T14:08:09Z

@oshoval - this change will help with issues like this - https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirtci/824/check-provision-k8s-1.24/1542137453714870272#1:build-log.txt%3A33 - can you take a look?

oshoval

Thanks

kubevirt-commenter-bot · 2022-06-29T22:17:51Z

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[da6af04 kind providers: Support Podman auto detection](kubevirt/kubevirtci#826) [5842a3c Update cluster provisioning image to fedora 36](kubevirt/kubevirtci#799) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>

[111fd50 cnao, Bump to v0.77.0 on all supported providers](kubevirt/kubevirtci#817) [010a2ec podman: Support non root user via root socket](kubevirt/kubevirtci#824) [da6af04 kind providers: Support Podman auto detection](kubevirt/kubevirtci#826) [5842a3c Update cluster provisioning image to fedora 36](kubevirt/kubevirtci#799) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>

jean-edouard · 2022-07-29T17:35:09Z

$ docker pull quay.io/fedora/fedora@sha256:38813cf0913241b7f13c7057e122f7c3cfa2e7c427dca3194f933d94612e280b
Error response from daemon: manifest for quay.io/fedora/fedora@sha256:38813cf0913241b7f13c7057e122f7c3cfa2e7c427dca3194f933d94612e280b not found: manifest unknown: manifest unknown

Am I doing something wrong? Also, any reason not to use quay.io/fedora/fedora:36?

brianmcarey · 2022-08-03T09:48:05Z

Am I doing something wrong? Also, any reason not to use quay.io/fedora/fedora:36?

It looks like old fedora images get cleaned up over time from quay. I would be in favour of just using quay.io/fedora/fedora:36 - it would prevent us from falling too far behind.

I see that it has been updated to use the kubevirtci mirror - #849 - but there could still be some value in pulling the latest f36 from quay.

oshoval · 2022-08-03T09:51:43Z

Am I doing something wrong? Also, any reason not to use quay.io/fedora/fedora:36?

It looks like old fedora images get cleaned up over time from quay. I would be in favour of just using quay.io/fedora/fedora:36 - it would prevent us from falling too far behind.

It might break with unknown errors from time to time, and less deterministic between reprovisions
especially when we are using something very new
we might want to have some cron update job that runs one a month ?
so it will be deterministic
see #847 (comment)
or to use only patch versions if possible but pin the major + minor

If the owners would tag the versions it wont get deleted - if we can ask them that ?

I see that it has been updated to use the kubevirtci mirror - #849 - but there could still be some value in pulling the latest f36 from quay.

Update cluster provisioning image to fedora 36

c78153b

Fedora 31 is no longer supported so we should update to use Fedora 36. This change also includes a bump to the dockerize version to the latest release. Signed-off-by: Brian Carey <[email protected]>

kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 23, 2022

kubevirt-bot requested review from dhiller and enp0s3 May 23, 2022 14:52

kubevirt-bot added the size/XS label May 23, 2022

kubevirt-bot added size/S and removed size/XS labels May 31, 2022

brianmcarey marked this pull request as ready for review May 31, 2022 16:50

kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2022

kubevirt-bot requested review from davidvossel and oshoval May 31, 2022 16:50

dankenigsberg reviewed Jun 2, 2022

View reviewed changes

brianmcarey added 2 commits June 2, 2022 13:39

brianmcarey force-pushed the cluster-provision-fedora-version branch from a922172 to b0c2120 Compare June 2, 2022 12:40

oshoval reviewed Jun 14, 2022

View reviewed changes

cluster-provision/centos8/Dockerfile Show resolved Hide resolved

dhiller approved these changes Jun 14, 2022

View reviewed changes

kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2022

kubevirt-bot assigned dhiller Jun 14, 2022

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2022

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2022

kubevirt-bot added size/M and removed lgtm Indicates that a PR is ready to be merged. size/S labels Jun 17, 2022

brianmcarey force-pushed the cluster-provision-fedora-version branch from bb98cde to b0c2120 Compare June 17, 2022 14:08

kubevirt-bot added size/S and removed size/M labels Jun 17, 2022

kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2022

oshoval reviewed Jun 20, 2022

View reviewed changes

oshoval approved these changes Jun 29, 2022

View reviewed changes

kubevirt-bot assigned oshoval Jun 29, 2022

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2022

kubevirt-bot merged commit 5842a3c into kubevirt:main Jun 30, 2022

kubevirt-bot mentioned this pull request Jul 5, 2022

Bump kubevirtci kubevirt/kubevirt#8048

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update cluster provisioning image to fedora 36 #799

Update cluster provisioning image to fedora 36 #799

brianmcarey commented May 23, 2022

kubevirt-bot commented May 23, 2022

brianmcarey commented May 23, 2022

brianmcarey commented May 31, 2022

brianmcarey commented Jun 1, 2022

dankenigsberg Jun 2, 2022

brianmcarey Jun 2, 2022

oshoval Jul 6, 2022

brianmcarey Jul 6, 2022

brianmcarey commented Jun 3, 2022

brianmcarey commented Jun 8, 2022

dhiller commented Jun 8, 2022 •

edited

Loading

dhiller left a comment

kubevirt-bot commented Jun 14, 2022

brianmcarey commented Jun 20, 2022

oshoval Jun 20, 2022 •

edited

Loading

brianmcarey Jun 20, 2022

brianmcarey commented Jun 29, 2022

oshoval left a comment

kubevirt-commenter-bot commented Jun 29, 2022

jean-edouard commented Jul 29, 2022 •

edited

Loading

brianmcarey commented Aug 3, 2022

oshoval commented Aug 3, 2022 •

edited

Loading

Update cluster provisioning image to fedora 36 #799

Update cluster provisioning image to fedora 36 #799

Conversation

brianmcarey commented May 23, 2022

kubevirt-bot commented May 23, 2022

brianmcarey commented May 23, 2022

brianmcarey commented May 31, 2022

brianmcarey commented Jun 1, 2022

dankenigsberg Jun 2, 2022

Choose a reason for hiding this comment

brianmcarey Jun 2, 2022

Choose a reason for hiding this comment

oshoval Jul 6, 2022

Choose a reason for hiding this comment

brianmcarey Jul 6, 2022

Choose a reason for hiding this comment

brianmcarey commented Jun 3, 2022

brianmcarey commented Jun 8, 2022

dhiller commented Jun 8, 2022 • edited Loading

dhiller left a comment

Choose a reason for hiding this comment

kubevirt-bot commented Jun 14, 2022

brianmcarey commented Jun 20, 2022

oshoval Jun 20, 2022 • edited Loading

Choose a reason for hiding this comment

brianmcarey Jun 20, 2022

Choose a reason for hiding this comment

brianmcarey commented Jun 29, 2022

oshoval left a comment

Choose a reason for hiding this comment

kubevirt-commenter-bot commented Jun 29, 2022

jean-edouard commented Jul 29, 2022 • edited Loading

brianmcarey commented Aug 3, 2022

oshoval commented Aug 3, 2022 • edited Loading

dhiller commented Jun 8, 2022 •

edited

Loading

oshoval Jun 20, 2022 •

edited

Loading

jean-edouard commented Jul 29, 2022 •

edited

Loading

oshoval commented Aug 3, 2022 •

edited

Loading