Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate mount error during provisioning #1032

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Fix duplicate mount error during provisioning #1032

merged 1 commit into from
Jun 21, 2023

Conversation

brianmcarey
Copy link
Member

@brianmcarey brianmcarey commented Jun 21, 2023 •
edited
Loading

Podman recently changed the handling of volumes at the container create
stage[1] to fix a bug[2] so when the bootstrap image was updated this
started failing in the check-provision lanes[3].

[1] containers/podman#18458
[2] containers/podman#18454
[3] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirtci/1024/check-provision-k8s-1.26-centos9/1670717915193675776#1:build-log.txt%3A2275

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Jun 21, 2023
@brianmcarey
Copy link
Member Author

/test check-provision-k8s-1.25
/test check-provision-k8s-1.26-centos9

@brianmcarey
Fix duplicate mount error during provisioning
1a0e6df 
Podman recently changed the handling of volumes at the container create
stage[1] to fix a bug[2] so when the bootstrap image was updated this
started failing in the check-provision lanes[3].

[1] containers/podman#18458
[2] containers/podman#18454
[3] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirtci/1024/check-provision-k8s-1.26-centos9/1670717915193675776#1:build-log.txt%3A2275

Signed-off-by: Brian Carey <[email protected]>
@brianmcarey brianmcarey force-pushed the fix-duplicate-mount-error branch from ffb81b0 to 1a0e6df Compare June 21, 2023 12:16
@brianmcarey
Copy link
Member Author

/cc @oshoval @dhiller @xpivarc

@brianmcarey brianmcarey marked this pull request as ready for review June 21, 2023 12:17
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2023
@kubevirt-bot kubevirt-bot requested review from ormergi and qinqon June 21, 2023 12:17
oshoval
oshoval approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice
Thanks

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2023
dhiller
dhiller approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2023
@kubevirt-bot kubevirt-bot merged commit 0c6367c into kubevirt:main Jun 21, 2023
@brianmcarey brianmcarey mentioned this pull request Jun 21, 2023
Merged
@kubevirt-bot kubevirt-bot mentioned this pull request Jun 24, 2023
Merged
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Jun 24, 2023
@kubevirt-bot
Bump kubevirtci
b71318a 
[f661bfe Provide usbs into VMs](kubevirt/kubevirtci#996)
[013718a Bump provisioning image to fedora 38](kubevirt/kubevirtci#1024)
[0d63ec2 pman: Update info about BYPASS_PMAN_CHANGE_CHECK](kubevirt/kubevirtci#1030)
[0c6367c Fix duplicate mount error during provisioning](kubevirt/kubevirtci#1032)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Jun 24, 2023
@kubevirt-bot
Bump kubevirtci
f12b429 
[f661bfe Provide usbs into VMs](kubevirt/kubevirtci#996)
[013718a Bump provisioning image to fedora 38](kubevirt/kubevirtci#1024)
[0d63ec2 pman: Update info about BYPASS_PMAN_CHANGE_CHECK](kubevirt/kubevirtci#1030)
[0c6367c Fix duplicate mount error during provisioning](kubevirt/kubevirtci#1032)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Jun 25, 2023
@kubevirt-bot
Bump kubevirtci
034843e 
[f661bfe Provide usbs into VMs](kubevirt/kubevirtci#996)
[013718a Bump provisioning image to fedora 38](kubevirt/kubevirtci#1024)
[0d63ec2 pman: Update info about BYPASS_PMAN_CHANGE_CHECK](kubevirt/kubevirtci#1030)
[0c6367c Fix duplicate mount error during provisioning](kubevirt/kubevirtci#1032)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Jun 25, 2023
@kubevirt-bot
Bump kubevirtci
e87b433 
[f661bfe Provide usbs into VMs](kubevirt/kubevirtci#996)
[013718a Bump provisioning image to fedora 38](kubevirt/kubevirtci#1024)
[0d63ec2 pman: Update info about BYPASS_PMAN_CHANGE_CHECK](kubevirt/kubevirtci#1030)
[0c6367c Fix duplicate mount error during provisioning](kubevirt/kubevirtci#1032)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Jun 26, 2023
@kubevirt-bot
Bump kubevirtci
75a26e1 
[f661bfe Provide usbs into VMs](kubevirt/kubevirtci#996)
[013718a Bump provisioning image to fedora 38](kubevirt/kubevirtci#1024)
[0d63ec2 pman: Update info about BYPASS_PMAN_CHANGE_CHECK](kubevirt/kubevirtci#1030)
[0c6367c Fix duplicate mount error during provisioning](kubevirt/kubevirtci#1032)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
akalenyu pushed a commit to akalenyu/kubevirt that referenced this pull request Jul 13, 2023
@kubevirt-bot @akalenyu
Bump kubevirtci
5bb7bc2 
[f661bfe Provide usbs into VMs](kubevirt/kubevirtci#996)
[013718a Bump provisioning image to fedora 38](kubevirt/kubevirtci#1024)
[0d63ec2 pman: Update info about BYPASS_PMAN_CHANGE_CHECK](kubevirt/kubevirtci#1030)
[0c6367c Fix duplicate mount error during provisioning](kubevirt/kubevirtci#1032)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
VirrageS pushed a commit to VirrageS/kubevirt that referenced this pull request Nov 17, 2023
@kubevirt-bot @VirrageS
Bump kubevirtci
ef1d91d 
[f661bfe Provide usbs into VMs](kubevirt/kubevirtci#996)
[013718a Bump provisioning image to fedora 38](kubevirt/kubevirtci#1024)
[0d63ec2 pman: Update info about BYPASS_PMAN_CHANGE_CHECK](kubevirt/kubevirtci#1030)
[0c6367c Fix duplicate mount error during provisioning](kubevirt/kubevirtci#1032)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshoval oshoval oshoval approved these changes

@dhiller dhiller dhiller approved these changes

@xpivarc xpivarc Awaiting requested review from xpivarc

@ormergi ormergi Awaiting requested review from ormergi

@qinqon qinqon Awaiting requested review from qinqon

Assignees

@dhiller dhiller

@oshoval oshoval

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brianmcarey @kubevirt-bot @dhiller @oshoval