compat container create: match duplicate mounts correctly #18458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic which checks for duplicated volumes here did not work correctly because it used filepath.Clean(). However the writes to the volDestinations map did not thus the string no longer matched when you included a final slash for example. So we can either call Clean() on all or no paths. I decided to call it on no path because this is what we do right now. Just the check did it. Fixed containers#18454 Signed-off-by: Paul Holzinger <[email protected]>
openshift-ci
bot
added
release-note
approved
github-actions
bot
added
the
kind/api-change
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
brianmcarey
added a commit
to brianmcarey/kubevirtci
that referenced
this pull request
Jun 21, 2023
Podman recently changed the handling of volumes at the container create stage[1] to fix a bug[2] so when the bootstrap image was updated this started failing in the check-provision lanes[3]. [1] containers/podman#18458 [2] containers/podman#18454 [3] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirtci/1024/check-provision-k8s-1.26-centos9/1670717915193675776#1:build-log.txt%3A2275 Signed-off-by: Brian Carey <[email protected]>
kubevirt-bot
pushed a commit
to kubevirt/kubevirtci
that referenced
this pull request
Jun 21, 2023
Podman recently changed the handling of volumes at the container create stage[1] to fix a bug[2] so when the bootstrap image was updated this started failing in the check-provision lanes[3]. [1] containers/podman#18458 [2] containers/podman#18454 [3] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirtci/1024/check-provision-k8s-1.26-centos9/1670717915193675776#1:build-log.txt%3A2275 Signed-off-by: Brian Carey <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic which checks for duplicated volumes here did not work correctly because it used filepath.Clean(). However the writes to the volDestinations map did not thus the string no longer matched when you included a final slash for example.
So we can either call Clean() on all or no paths. I decided to call it on no path because this is what we do right now. Just the check did it.
Fixed #18454
Does this PR introduce a user-facing change?