Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNV-51546: Vm not foun #2409

Merged
merged 1 commit into from
Feb 3, 2025
Merged

CNV-51546: Vm not foun #2409

merged 1 commit into from
Feb 3, 2025
+117 −23

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented Jan 31, 2025 •
edited
Loading

📝 Description

Adding some error handling for different status codes

Depends on #2408

🎥 Demo

Access Denied

Screenshot 2025-01-31 at 15 51 32

Not found

Screenshot 2025-01-31 at 15 44 15

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jan 31, 2025
@upalatucci upalatucci changed the title Vm not foun CNV-51546: Vm not foun Jan 31, 2025
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 31, 2025 •
edited by openshift-ci bot
Loading

@upalatucci: This pull request references CNV-51546 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

📝 Description

Adding some error handling for different status codes

Depends on #2408

🎥 Demo

Access Denied

Screenshot 2025-01-31 at 15 51 32

Not found

Screenshot 2025-01-31 at 15 44 15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

avivtur
avivtur reviewed Feb 2, 2025
View reviewed changes
Copy link
Member

@avivtur avivtur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this build on top of #2408 should we hold with this untils it's merged?

@upalatucci upalatucci changed the title CNV-51546: Vm not foun [WIP] CNV-51546: Vm not foun Feb 3, 2025
@upalatucci upalatucci changed the title [WIP] CNV-51546: Vm not foun CNV-51546: Vm not foun Feb 3, 2025
@metalice
Copy link
Member

metalice commented Feb 3, 2025

/retest

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Feb 3, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4896230 into kubevirt-ui:main Feb 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avivtur avivtur avivtur left review comments

@metalice metalice metalice approved these changes

@vojtechszocs vojtechszocs Awaiting requested review from vojtechszocs

Assignees

@metalice metalice

Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@upalatucci @openshift-ci-robot @metalice @avivtur