CNV-55107: loading on vm change #2408
Conversation
|
@upalatucci: This pull request references CNV-55107 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
upalatucci
force-pushed
the
loading-vm
branch
from
ad06d00 to
255aab0
Compare
|
@upalatucci: This pull request references CNV-55107 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| params={params} | ||
| {...props} | ||
| /> | ||
| <StateHandler loaded={!expandedSpecLoading} withBullseye> |
There was a problem hiding this comment.
how this works for VMs created with templates or YML?
There was a problem hiding this comment.
works great. THe expandedSpecLoading is false from the start with template vms
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
On VM change, we wait only for the VM to be fetched. We should also wait for the instancetype spec expansion request
Changing VMs without waiting will make the screen flickering between the previous instance and the other
🎥 Demo
Before
Screen.Recording.2025-01-31.at.15.14.37.mov
After
Screen.Recording.2025-01-31.at.15.10.49.mov