Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNV-45822: Vm tree view 2 #2282

Merged
merged 1 commit into from
Nov 28, 2024
Merged

CNV-45822: Vm tree view 2 #2282

merged 1 commit into from
Nov 28, 2024

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Nov 24, 2024

📝 Description

Adding status summary to VM list view

🎥 Demo

vm-summary-opened

Note: This PR is built on top of #2248

@openshift-ci openshift-ci bot requested review from metalice and pcbailey November 24, 2024 09:23
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Nov 24, 2024
@avivtur avivtur changed the title Vm tree view 2 [WIP] CNV-45822: Vm tree view 2 Nov 24, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 24, 2024 •
edited by openshift-ci bot
Loading

@avivtur: This pull request references CNV-45822 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.18.0" instead.

In response to this:

📝 Description

Adding status summary to VM list view

🎥 Demo

vm-summary-opened

Note: This PR is built on top of #2248

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@avivtur avivtur force-pushed the vm-tree-view-2 branch 2 times, most recently from 88f0fb2 to 323b2cc Compare November 25, 2024 08:41
@avivtur avivtur changed the title [WIP] CNV-45822: Vm tree view 2 CNV-45822: Vm tree view 2 Nov 25, 2024
pcbailey
pcbailey reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@pcbailey pcbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I just had one nitpick suggestion.

...iews/virtualmachines/list/components/VirtualMachineListSummary/VirtualMachineListSummary.tsx Outdated Show resolved Hide resolved
@avivtur
CNV-45822: Tree view part 2
b76d373 
Signed-off-by: Aviv Turgeman <[email protected]>
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Nov 28, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 34b244d into kubevirt-ui:main Nov 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcbailey pcbailey pcbailey left review comments

@upalatucci upalatucci upalatucci approved these changes

@metalice metalice Awaiting requested review from metalice

Assignees

@upalatucci upalatucci

Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@avivtur @openshift-ci-robot @pcbailey @metalice @upalatucci