CNV-45822: Tree view part 1 #2248
Conversation
|
@avivtur: This pull request references CNV-45822 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.18.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
avivtur
force-pushed
the
vm-tree-view-1
branch
5 times, most recently
from
871c545 to
0d51a7c
Compare
|
@avivtur: This pull request references CNV-45822 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.18.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
avivtur
force-pushed
the
vm-tree-view-1
branch
from
0d51a7c to
33f4711
Compare
avivtur
force-pushed
the
vm-tree-view-1
branch
from
0636320 to
0cd4db4
Compare
|
@avivtur: This pull request references CNV-45822 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.18.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
avivtur
force-pushed
the
vm-tree-view-1
branch
from
0cd4db4 to
7d84398
Compare
avivtur
force-pushed
the
vm-tree-view-1
branch
from
7d84398 to
292e568
Compare
avivtur
force-pushed
the
vm-tree-view-1
branch
from
292e568 to
43da888
Compare
avivtur
force-pushed
the
vm-tree-view-1
branch
2 times, most recently
from
0fd1042 to
158d2e6
Compare
avivtur
force-pushed
the
vm-tree-view-1
branch
from
158d2e6 to
4eb598d
Compare
avivtur
changed the title
avivtur
force-pushed
the
vm-tree-view-1
branch
from
4eb598d to
361476d
Compare
|
@avivtur: This pull request references CNV-45822 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.18.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
avivtur
force-pushed
the
vm-tree-view-1
branch
2 times, most recently
from
05c6e97 to
2223090
Compare
avivtur
changed the title
avivtur
force-pushed
the
vm-tree-view-1
branch
3 times, most recently
from
b2e03fc to
f374fdd
Compare
|
/retest |
|
|
||
| const { filteredItems, onSearch, setShowAll, showAll } = useTreeViewSearch(treeData); | ||
|
|
||
| useSyncClicksEffects(activeNamespace, loaded, location); |
There was a problem hiding this comment.
do we still need it? even after hiding the ns bar? activeNamespace isn't enough?
There was a problem hiding this comment.
This is still needed to be in sync with vm list click not from treeview
Signed-off-by: Aviv Turgeman <[email protected]>
avivtur
force-pushed
the
vm-tree-view-1
branch
from
f374fdd to
656f212
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
Adding a tree view display to VM perspective
NOTE: The transition from a single VM to a folder view which filters the VMs by folder is not working for now.
🎥 Demo
Admin:
Non-admin: (all projects does not appear)