Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-44365: New Virtualization Perspective #2128

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,4 @@
{
"files.associations": {
"console-extensions.json": "jsonc"
},
"json.schemas": [
{
"fileMatch": ["console-extensions.json"],
"url": "/node_modules/@openshift-console/dynamic-plugin-sdk-webpack/schema/console-extensions.json"
}
],
"search.exclude": {
"**/node_modules": true,
"**/.yarn": true,
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ conster Header: React.FC = () => {
};
```

For labels in `console-extensions.json`, you should use the format
For labels in console extensions files, you should use the format
`%plugin__kubevirt-plugin~My Label%`. Console will replace the value with
the message for the current language from the `plugin__kubevirt-plugin`
namespace. For example:
Expand All @@ -109,7 +109,7 @@ namespace. For example:

Note that you will need to include a comment in `utils/i18n.ts` like the
following for [i18next-parser](https://github.com/i18next/i18next-parser) to
add the message from `console-extensions.json` to your message catalog as follows:
add the message from console extensions files to your message catalog as follows:

```ts
// t('plugin__kubevirt-plugin~VirtualMachines')
Expand Down
Loading
Loading