CNV-44365: New Virtualization Perspective #2128
Conversation
|
@upalatucci: This pull request references CNV-44365 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.17.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@upalatucci: This pull request references CNV-44365 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.17.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@upalatucci: This pull request references CNV-44365 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "CNV v4.17.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
upalatucci
force-pushed
the
new-virt-perspective
branch
from
c10b4d8 to
b3c3bef
Compare
upalatucci
force-pushed
the
new-virt-perspective
branch
from
b3c3bef to
d481569
Compare
package.json
Outdated
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "dependencies": { | |||
| "@novnc/novnc": "1.3.0", | |||
| "@openshift/dynamic-plugin-sdk": "^5.0.1", | |||
There was a problem hiding this comment.
is this necessary? As a dynamic plugin we should stick to @openshift-console, but not sure about this, @vojtechszocs can you enlighten us on this?
There was a problem hiding this comment.
@avivtur Hi, I've talked about this with @upalatucci and for now, we can import EncodedExtension from package @openshift/dynamic-plugin-sdk-webpack since @openshift-console/dynamic-plugin-sdk-webpack depends on that package.
Aviv is right that we should not import directly from OpenShift plugin SDK (instead of from Console plugin SDK) unless we have a very good reason to do so.
I'll post a Console PR to expose EncodedExtension type via Console plugin SDK directly to address this gap.
There was a problem hiding this comment.
@vojtechszocs Thank you for the explanation :)
There was a problem hiding this comment.
openshift/console#14167 should address this issue.
upalatucci
force-pushed
the
new-virt-perspective
branch
from
d481569 to
d7ed773
Compare
upalatucci
force-pushed
the
new-virt-perspective
branch
from
d7ed773 to
8e3078e
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
Add
Virtualizationperspective with just virtualization, networking, storage and observe sectionsRemove console-extension.json to split file into different dynamic-plugin.ts files
🎥 Demo