Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re: Issue #6976 - Registry secret type and datakey updated for 1.9 #7248

Merged
merged 1 commit into from
Feb 7, 2018
Merged

re: Issue #6976 - Registry secret type and datakey updated for 1.9 #7248

merged 1 commit into from
Feb 7, 2018

Conversation

aburdenthehand
Copy link
Contributor

@aburdenthehand aburdenthehand commented Feb 6, 2018 •
edited by k8s-reviewable
Loading

kubectl 1.9+ updated registry secret type and datakey: 's/.dockercfg/.dockerconfigjson, and datakey now wrapped in 'auths' element. See kubernetes/kubernetes#57427 for more information.

Checked against kubectl 1.9.2

Allow edits from maintainers checkbox

This change is Reviewable

@aburdenthehand
kubectl 1.9+ updated registry secret type and datakey: .dockercfg is …
5064ea8 
…now .dockerconfigjson, and datakey now wrapped in 'auths' element
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 6, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5064ea8

https://deploy-preview-7248--kubernetes-io-master-staging.netlify.com

@aburdenthehand aburdenthehand mentioned this pull request Feb 6, 2018
Closed
1 task
@xiangpengzhao
Copy link
Contributor

/cc @liggitt @juanvallejo

@k8s-ci-robot k8s-ci-robot requested a review from liggitt February 6, 2018 02:30
@k8s-ci-robot
Copy link
Contributor

@xiangpengzhao: GitHub didn't allow me to request PR reviews from the following users: juanvallejo.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @liggitt @juanvallejo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juanvallejo
Copy link
Contributor

This lgtm

@heckj
Copy link
Contributor

heckj commented Feb 7, 2018

thanks @juanvallejo !

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aburdenthehand, heckj

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2018
@k8s-ci-robot k8s-ci-robot merged commit 169f527 into kubernetes:master Feb 7, 2018
chenopis added a commit that referenced this pull request Feb 8, 2018
@chenopis
Merge branch 'master' of https://github.com/kubernetes/website into i18n
ebd3f64 
* 'master' of https://github.com/kubernetes/website: (379 commits)
  fix some typos in keps.md (#7266)
  Typo fix: recommend -> recommended (#7271)
  Update nodes.md (#7288)
  Fix patch image command in rolling update section (#7124)
  fix edx link (#7276)
  Update OWNERS_ALIASES for sig-openstack (#7280)
  Update ISSUE_TEMPLATE.md (#7284)
  Add Brad Topol to owner aliases. (#7246)
  modify the default update strategy of statefulset (#7270)
  Fix tags of workloads-related glossary (#7102)
  kubectl 1.9+ updated registry secret type and datakey: .dockercfg is now .dockerconfigjson, and datakey now wrapped in 'auths' element (#7248)
  Remove CentOS guide that was already deprecated a while ago (#7242)
  fix typo (#7260)
  fix typo envrionment -> [environment] (#7262)
  fix a typo in kubernetes api (#7261)
  fix some typos (#7251)
  Update notes.md (#7259)
  Update notes.md (#7257)
  Fix file extension and remove not necessary sudo. (#7143)
  Update Azure Container Service to managed clusters (#6955)
  ...
tehut pushed a commit to tehut/website that referenced this pull request Feb 20, 2018
@aburdenthehand @tehut
kubectl 1.9+ updated registry secret type and datakey: .dockercfg is …
099b113 
…now .dockerconfigjson, and datakey now wrapped in 'auths' element (kubernetes#7248)
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Feb 23, 2018
@aburdenthehand @bsalamat
kubectl 1.9+ updated registry secret type and datakey: .dockercfg is …
14a822e 
…now .dockerconfigjson, and datakey now wrapped in 'auths' element (kubernetes#7248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanvallejo juanvallejo juanvallejo approved these changes

@tengqm tengqm Awaiting requested review from tengqm

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@heckj heckj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aburdenthehand @k8sio-netlify-preview-bot @xiangpengzhao @k8s-ci-robot @juanvallejo @heckj