Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CentOS guide that was already deprecated a while ago #7242

Merged
merged 1 commit into from
Feb 7, 2018

Conversation

errordeveloper
Copy link
Member

@errordeveloper errordeveloper commented Feb 5, 2018

As we've discussed between sig-cluster-lifecycle and sig-docs a few weeks ago, there are getting started guides that are evidently out of date and will need to be updated and pass conformance.

In the process of identifying guide owners and maintainers, it was evident that this CentOS guide can be removed safely.

cc @lavalamp @thockin @chenopis


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 5, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Feb 5, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4abb13d

https://deploy-preview-7242--kubernetes-io-master-staging.netlify.com

@errordeveloper
Copy link
Member Author

/approve

@lavalamp
Copy link
Member

lavalamp commented Feb 5, 2018

Gave the tech lgtm label. 1.1 setup guide is definitely not useful at this point.

_redirects Outdated
@@ -179,6 +179,9 @@
/docs/getting-started-guides/vagrant/ /docs/getting-started-guides/alternatives/ 301
/docs/getting-started-guides/windows/While/ /docs/getting-started-guides/windows/ 301

/docs/getting-started-guides/centos/* /docs/setup/independent/create-cluster-kubeadm/ 301
/cn/docs/getting-started-guides/centos/* /docs/setup/independent/create-cluster-kubeadm/ 301
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cn docs are not actively maintained in this repo, so we don't need this line I think. cc @markthink @hanjiayao for confirmation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've remove it.

@xiangpengzhao
Copy link
Contributor

/lgtm
/assign @chenopis

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2018
@heckj
Copy link
Contributor

heckj commented Feb 7, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: errordeveloper, heckj, xiangpengzhao

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2018
@k8s-ci-robot k8s-ci-robot merged commit e81fe48 into kubernetes:master Feb 7, 2018
@errordeveloper errordeveloper deleted the gsg-cleanup branch February 7, 2018 16:11
chenopis added a commit that referenced this pull request Feb 8, 2018
* 'master' of https://github.com/kubernetes/website: (379 commits)
  fix some typos in keps.md (#7266)
  Typo fix: recommend -> recommended (#7271)
  Update nodes.md (#7288)
  Fix patch image command in rolling update section (#7124)
  fix edx link (#7276)
  Update OWNERS_ALIASES for sig-openstack (#7280)
  Update ISSUE_TEMPLATE.md (#7284)
  Add Brad Topol to owner aliases. (#7246)
  modify the default update strategy of statefulset (#7270)
  Fix tags of workloads-related glossary (#7102)
  kubectl 1.9+ updated registry secret type and datakey: .dockercfg is now .dockerconfigjson, and datakey now wrapped in 'auths' element (#7248)
  Remove CentOS guide that was already deprecated a while ago (#7242)
  fix typo (#7260)
  fix typo envrionment -> [environment] (#7262)
  fix a typo in kubernetes api (#7261)
  fix some typos (#7251)
  Update notes.md (#7259)
  Update notes.md (#7257)
  Fix file extension and remove not necessary sudo. (#7143)
  Update Azure Container Service to managed clusters (#6955)
  ...
tehut pushed a commit to tehut/website that referenced this pull request Feb 20, 2018
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants