-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CentOS guide that was already deprecated a while ago #7242
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 4abb13d https://deploy-preview-7242--kubernetes-io-master-staging.netlify.com |
/approve |
Gave the tech lgtm label. 1.1 setup guide is definitely not useful at this point. |
_redirects
Outdated
@@ -179,6 +179,9 @@ | |||
/docs/getting-started-guides/vagrant/ /docs/getting-started-guides/alternatives/ 301 | |||
/docs/getting-started-guides/windows/While/ /docs/getting-started-guides/windows/ 301 | |||
|
|||
/docs/getting-started-guides/centos/* /docs/setup/independent/create-cluster-kubeadm/ 301 | |||
/cn/docs/getting-started-guides/centos/* /docs/setup/independent/create-cluster-kubeadm/ 301 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cn docs are not actively maintained in this repo, so we don't need this line I think. cc @markthink @hanjiayao for confirmation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've remove it.
1bb5b6d
to
4abb13d
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: errordeveloper, heckj, xiangpengzhao The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
* 'master' of https://github.com/kubernetes/website: (379 commits) fix some typos in keps.md (#7266) Typo fix: recommend -> recommended (#7271) Update nodes.md (#7288) Fix patch image command in rolling update section (#7124) fix edx link (#7276) Update OWNERS_ALIASES for sig-openstack (#7280) Update ISSUE_TEMPLATE.md (#7284) Add Brad Topol to owner aliases. (#7246) modify the default update strategy of statefulset (#7270) Fix tags of workloads-related glossary (#7102) kubectl 1.9+ updated registry secret type and datakey: .dockercfg is now .dockerconfigjson, and datakey now wrapped in 'auths' element (#7248) Remove CentOS guide that was already deprecated a while ago (#7242) fix typo (#7260) fix typo envrionment -> [environment] (#7262) fix a typo in kubernetes api (#7261) fix some typos (#7251) Update notes.md (#7259) Update notes.md (#7257) Fix file extension and remove not necessary sudo. (#7143) Update Azure Container Service to managed clusters (#6955) ...
As we've discussed between sig-cluster-lifecycle and sig-docs a few weeks ago, there are getting started guides that are evidently out of date and will need to be updated and pass conformance.
In the process of identifying guide owners and maintainers, it was evident that this CentOS guide can be removed safely.
cc @lavalamp @thockin @chenopis
This change is