Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ar] Fix build error due to bad tooltip label #47820

Conversation

adowair
Copy link

@adowair adowair commented Sep 6, 2024

Description

This commit will fix a build error due to what seems to be a typo, where the term_id and text field for a glossary tooltip were switched.

Issue

See this build failure in #47819

This commit will fix a build error due to what seems to be a typo,
where the term_id and text field for a glossary tooltip were switched.

Signed-off-by: Ali Dowair <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ar Issues or PRs related to Arabic language labels Sep 6, 2024
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 6, 2024
Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for kubernetes-io-ar-staging ready!

Name Link
🔨 Latest commit 2c6b6fd
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-ar-staging/deploys/66e0833c8c7dd60008f0b54a
😎 Deploy Preview https://deploy-preview-47820--kubernetes-io-ar-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 6, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2c6b6fd
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66e0833c0eb7730008062c13
😎 Deploy Preview https://deploy-preview-47820--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

linux-foundation-easycla bot commented Sep 10, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 10, 2024
@adowair
Copy link
Author

adowair commented Sep 10, 2024

/check-cla

This commit will update the affected line to retain the original
translation for control plane "مستوى" rather than "سطح".
It also updates the spelling of "kubernetes" to match the latest
localization standard.

Signed-off-by: Ali Dowair <[email protected]>
@adowair adowair force-pushed the dev-1.29-ar.1-fix-build-err-tooltip branch from 3c94187 to 2c6b6fd Compare September 10, 2024 17:34
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 10, 2024
@salaxander salaxander added area/localization General issues or PRs related to localization labels Sep 10, 2024
@adowair adowair requested a review from mboukhalfa September 11, 2024 10:58
@adowair
Copy link
Author

adowair commented Sep 14, 2024

Hi @mboukhalfa @seifrajhi it looks like this PR has passed the checks and is awaiting reviews. Thanks in advance!

@seifrajhi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0b30c6922692392b76a7b0d8efbe519a267c1ac7

@seifrajhi
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seifrajhi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit f9e5962 into kubernetes:dev-1.29-ar.1 Sep 14, 2024
6 checks passed
@adowair adowair deleted the dev-1.29-ar.1-fix-build-err-tooltip branch September 15, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ar Issues or PRs related to Arabic language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants