Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KEP-4006] Blog Post: Streaming Transition from SPDY to WebSockets is Beta #46971

Merged
merged 1 commit into from
Aug 17, 2024
Merged

[KEP-4006] Blog Post: Streaming Transition from SPDY to WebSockets is Beta #46971

merged 1 commit into from
Aug 17, 2024

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Jun 25, 2024 •
edited
Loading

Streaming Transition from SPDY to Websocket Blog Post

kubernetes/enhancements#4006

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 25, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 25, 2024
@seans3 seans3 mentioned this pull request Jun 25, 2024
Open
8 tasks
@netlify Netlify
Copy link

netlify bot commented Jun 25, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit bd6c9f1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66bd2736a0ac650008f858c4
😎 Deploy Preview https://deploy-preview-46971--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@seans3 seans3 marked this pull request as draft June 25, 2024 17:38
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2024
@a-mccarthy
Copy link
Contributor

/hold

Pending assignment of publication date (by release comms)

We'll also keep this held until the v1.31 release has happened

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2024
@SsomsakTH SsomsakTH mentioned this pull request Jul 7, 2024
Closed
@edithturn
Copy link
Contributor

edithturn commented Jul 16, 2024 •
edited
Loading

Hello @seans3 🙂 , it's Edith Puclla from the 1.31 Release comms team.

A friendly reminder that the deadline for the blog to be ready for review is July 26, 2024.

Let me know if there's anything we can do to help with content, review, or anything else! 🙂

@seans3
Copy link
Contributor Author

seans3 commented Jul 16, 2024

Hello Sean Sullivan 🙂 , it's Edith Puclla from the 1.31 Release comms team.

A friendly reminder that the deadline for the blog to be ready for review is July 26, 2024.

Let me know if there's anything we can do to help with content, review, or anything else! 🙂

Acknowledged--thanks :) I may be in touch to get more clarity on expectations.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2024
@seans3 seans3 marked this pull request as ready for review July 26, 2024 04:06
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2024
@seans3
Copy link
Contributor Author

seans3 commented Jul 26, 2024

Hello @seans3 🙂 , it's Edith Puclla from the 1.31 Release comms team.

A friendly reminder that the deadline for the blog to be ready for review is July 26, 2024.

Let me know if there's anything we can do to help with content, review, or anything else! 🙂

Please have a look and let me know what you think. And if there is a more solid date, I'll update it in the PR. Thanks

@tengqm
Copy link
Contributor

tengqm commented Jul 26, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2024
@seans3
Copy link
Contributor Author

seans3 commented Jul 26, 2024

/assign @edithturn

@seans3
Copy link
Contributor Author

seans3 commented Jul 26, 2024

/assign @liggitt
/assign @aojea

@edithturn
Copy link
Contributor

This is written as if the v1.31 release is in the future, which is true now but won't be at publication time. It's not ready yet, but the fixes needed are minor.

Hello @sftim , could you please

Thanks
This is written as if the v1.31 release is in the future, which is true now but won't be at publication time. It's not ready yet, but the fixes needed are minor.
/approve cancel

Thanks for the feedback. I think I've addressed the issues you raised. Please have a look.

Hi @sftim!
Could you please help us to check what @seans3 mentioned? 🙂

@sftim
Copy link
Contributor

sftim commented Aug 5, 2024

Hi @sftim! Could you please help us to check what @seans3 mentioned? 🙂

Any blog reviewer is welcome to move this forward, not just me.

divya-mohan0209
divya-mohan0209 reviewed Aug 14, 2024
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2024
sftim
sftim reviewed Aug 14, 2024
View reviewed changes
content/en/blog/_posts/2024-08-20-websocket-transition.md Outdated
@@ -0,0 +1,115 @@
---
layout: blog
title: 'Streaming Transitions from SPDY to WebSockets'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the title mention Kubernetes 1.31? A typical post-release article does.

/lgtm cancel

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be:
title: "Kubernetes 1.31: Streaming Transitions from SPDY to WebSockets"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2024
edithturn
edithturn reviewed Aug 14, 2024
View reviewed changes
content/en/blog/_posts/2024-08-20-websocket-transition.md Outdated
`kubectl cp`, `kubectl attach`, `kubectl exec`, and `kubectl port-forward`
stop working when you try to access your cluster through a proxy or gateway.

As of Kubernetes v1.31, SIG API Machinery have modified the streaming
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor typo:
It should be: "SIG API Machinery has modified the streaming..."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either's fine with me, but I don't speak US English.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have changed to has

edithturn
edithturn reviewed Aug 14, 2024
View reviewed changes
content/en/blog/_posts/2024-08-20-websocket-transition.md Outdated

## Learn more about streaming APIs

- [KEP 4006 - Transitioning from SPDY to Websockets](https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/4006-transition-spdy-to-websockets)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:
It should be "WebSockets"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

edithturn
edithturn reviewed Aug 14, 2024
View reviewed changes
content/en/blog/_posts/2024-08-20-websocket-transition.md Outdated
## Learn more about streaming APIs

- [KEP 4006 - Transitioning from SPDY to Websockets](https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/4006-transition-spdy-to-websockets)
- [RFC 6455 - The Websocket Protocol](https://datatracker.ietf.org/doc/html/rfc6455)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:
It should be "WebSockets"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

divya-mohan0209
divya-mohan0209 reviewed Aug 17, 2024
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since all comments seem to have been addressed. Please feel free to unhold @mbianchidev!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a2f28c647bba8db8c9eeb3b2e4cf915e3f797155

@mbianchidev
Copy link
Member

/unhold

Kubernetes v1.31 has been released.

Thanks @divya-mohan0209 !

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 28124f6 into kubernetes:main Aug 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edithturn edithturn edithturn left review comments

@mbianchidev mbianchidev mbianchidev requested changes

@shannonxtreme shannonxtreme shannonxtreme left review comments

@sftim sftim sftim left review comments

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@Gauravpadam Gauravpadam Awaiting requested review from Gauravpadam

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@aojea aojea Awaiting requested review from aojea

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@aojea aojea

@divya-mohan0209 divya-mohan0209

@sftim sftim

@edithturn edithturn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.