-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bn] merging main in to dev-1.24-bn.1 #46246
Conversation
Remove Redundant 'the' word in pod-lifecycle.md
Update vi.toml
Signed-off-by: xin.li <[email protected]>
Revise authorization topic
Update doc title Rename file/update link Update api_metadata Update what's next Remove api_metadata, add tootip
Resync kubelet reference for 1.30
Remove 1.30 leads from sig-docs-website-owners
…unity Ready community pages for vanilla Docsy
[zh-cn]sync network-plugins field-selectors replicaset statefulset
[zh] sync resize-container-resources user-namespaces
Signed-off-by: ydFu <[email protected]>
Signed-off-by: tico88612 <[email protected]> [zh-ch] Add the LimitRange en metadata Signed-off-by: tico88612 <[email protected]> [zh-cn] Add api_reference_title translation Signed-off-by: tico88612 <[email protected]>
Signed-off-by: tico88612 <[email protected]>
Update 2023 blog content files to move author details in front-matter
Update documented metrics for v1.30
Add missing check-required-ports anchor
* Adds a new lines to documents explaining that this section assumes we have created a kuberentes-bootcamp service with LoadBalancer type * Update content/en/docs/tutorials/kubernetes-basics/scale/scale-intro.html Co-authored-by: Anuj Tiwari <[email protected]> * Update content/en/docs/tutorials/kubernetes-basics/scale/scale-intro.html Co-authored-by: Anuj Tiwari <[email protected]> * Update content/en/docs/tutorials/kubernetes-basics/scale/scale-intro.html Co-authored-by: Anuj Tiwari <[email protected]> * Update content/en/docs/tutorials/kubernetes-basics/scale/scale-intro.html Co-authored-by: Tim Bannister <[email protected]> * Update content/en/docs/tutorials/kubernetes-basics/scale/scale-intro.html Co-authored-by: Tim Bannister <[email protected]> * Update content/en/docs/tutorials/kubernetes-basics/scale/scale-intro.html Rephrase Co-authored-by: Tim Bannister <[email protected]> * Update scale-intro.html Fixed typo: Sservice -> service --------- Co-authored-by: Anuj Tiwari <[email protected]> Co-authored-by: Tim Bannister <[email protected]>
Update "app.kubernetes.io/managed-by" annotation example value
…be apiserver-audit.v1 Signed-off-by: xin.li <[email protected]>
[zh-cn] sync only update `api_metadata` docs
[zh-cn]sync policy kubernetes-api kubeadm-config.v1beta3 hello-minikube apiserver-audit.v1
Fix typo in 'Jobs' concept page
Update encrypt-data.md
Updating OWNERS_ALIASES with final changes
[zh] sync control-plane-flags encrypt-data
Signed-off-by: xin.li <[email protected]>
[ja] revise `content/ja/docs/contribute/localization.md`
[ja] Ready training section for vanilla Docsy
[ja] Update content/ja/docs/tasks/tools/included/optional-kubectl-configs-bash-mac.md
/lgtm Considering this PR is to update dev-1.24-bn.1 branch to make it up to date (from upstream/main) and there is no merge conflict. This PR will help reducing merge conflict when we try to merge dev-1.24-bn.1 into main branch for the first live version of Bengali localization. :) Note that I am not sure any possible build errors exist in the dev-1.24-bn.1 (Netlify build test is for main branch), if there is, we need to fix it in the dev branch. |
LGTM label has been added. Git tree hash: 1b6a19be3e63ff32e808d85d3a45ab410a80b824
|
For any PR, you can always pull it locally and run a test to confirm that it builds OK. |
@seokho-son Actually, yes, we have build errors, but most of them are glossary-related. We are already working on that. |
[zh-cn] sync apiserver-admission.v1 imagepolicy.v1alpha1
New changes are detected. LGTM label has been removed. |
[zh] Sync 9 reference files in setup-tools/kubeadm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My two cents on this issue.
This is a very large change, and I haven't seen a precedent for it earlier on despite also being a maintainer for the Hindi localisation. I understand that we're very close to the minimum requirement, and it'd help if we approved this change, but I'm also wary of such changes being forced through for a localisation because certain files are missing.
I'd rather have the second approach listed on this PR by
@sftim followed and would not recommend the approach of merging main into the dev branch like we do for branch syncs during a release.
@natalisucks @reylejano : I would like your thoughts on this, as well.
Technically the dev-1.24-bn.1 branch was created from what was the 1.24 docs. The main branch is currently for the 1.30 docs and will be a very large change. I don't think we should merge main into dev-1.24-bn.1. |
@divya-mohan0209 Thanks for suggestion , we are going with option 2 from this #46210 (comment) now |
@asem-hamid Can we close this PR, please, if we're following option 2? |
ok |
Merging main in to dev-1.24-bn.1 to update dev-1.24-bn.1 branch
Fixes Issue : #44993
Tracking Issue: #31677
/cc @sftim
/cc @seokho-son
/cc @a-mccarthy
/cc @dipesh-rawat
/cc @divya-mohan0209