Ready community pages for vanilla Docsy #45872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/web-development
k8s-ci-robot
added
the
sig/docs
sftim
commented
Apr 14, 2024
content/en/community/values.md
Outdated
There was a problem hiding this comment.
Removed because: the page is deprecated. I can split this into a separate PR if we want that.
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sftim
commented
Apr 14, 2024
| @@ -613,6 +613,44 @@ body.cid-community > #deprecation-warning > .deprecation-warning > * { | |||
| background-color: inherit; | |||
| } | |||
|
|
|||
| body.cid-code-of-conduct main { | |||
There was a problem hiding this comment.
This is based on the existing static CSS.
sftim
force-pushed
the
20240414_vanillaify_content_community
branch
from
924ce5c to
7adae45
Compare
Align how we style the community section to work more the way Docsy expects it to.
sftim
force-pushed
the
20240414_vanillaify_content_community
branch
from
5718c20 to
b78e1cd
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dipesh-rawat, reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thanks |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 48ea73fe02134bac4fdd47a64bab1787055dfb73
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align how we style the community section to work more the way Docsy expects it to.
The way this works is to set
menufront matter that Docsy would display in a reasonable way.Along with that, I've changed the CSS so that it doesn't depend on pulling in a special file, and to support that I'm dropping some legacy
<center>elements.Existing section index | Preview
/area web-development
Helps with issue #41171