Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ar] translate setup/_index.md #45094

Merged
merged 1 commit into from
Jul 5, 2024
Merged

[ar] translate setup/_index.md #45094

merged 1 commit into from
Jul 5, 2024

Conversation

essamgouda97
Copy link

@essamgouda97 essamgouda97 commented Feb 12, 2024 •
edited
Loading

This PR will create a new file contents/docs/ar/setup/_index.md that is translated into arabic following the english docs.
Following the plan in this PR: #37546.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2024
@essamgouda97
Copy link
Author

/language ar

@k8s-ci-robot k8s-ci-robot added the language/ar Issues or PRs related to Arabic language label Feb 12, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 12, 2024
@essamgouda97 essamgouda97 changed the title translate setup/_index.md [ar] translate setup/_index.md Feb 12, 2024
mboukhalfa
mboukhalfa approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@mboukhalfa mboukhalfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Arabic

some suggestions and nits :

content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
@adowair adowair mentioned this pull request Feb 12, 2024
Closed
@essamgouda97
Copy link
Author

@mboukhalfa resolved your comments, let me know if more changes are needed, if not I will squash.

@mboukhalfa
Copy link
Member

LGTM for Arabic

adowair
adowair suggested changes Feb 13, 2024
View reviewed changes
Copy link

@adowair adowair left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work @essamgouda97! I've made several suggestions for grammar and sentence structure. Please take a look and LMK what you think. I've also made suggestions to unify the spelling of "kubernetes" (كوبرناتيز); we haven't decided yet on a unified translation, but this will make it easier to search+replace later when we do.

content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
@essamgouda97
Copy link
Author

Thanks @adowair addressed all your comments !

adowair
adowair approved these changes Feb 22, 2024
View reviewed changes
Copy link

@adowair adowair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Arabic. Thank you @essamgouda97 for the work. Just one extra whitespace, but otherwise good to merge!

content/ar/docs/setup/_index.md Outdated Show resolved Hide resolved
@mboukhalfa
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a0a93a4fd764a86b4113c1ad96d700ae680e7be9

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2024
@essamgouda97 essamgouda97 requested a review from adowair February 26, 2024 17:12
adowair
adowair approved these changes Feb 27, 2024 •
edited
Loading
View reviewed changes
@adowair adowair mentioned this pull request Mar 16, 2024
Closed
9 tasks
@mboukhalfa
Copy link
Member

/approve

@mboukhalfa
Copy link
Member

@essamgouda97 you might need to rebase your PR

@mboukhalfa
Copy link
Member

/approve

2 similar comments
@mboukhalfa
Copy link
Member

/approve

@mboukhalfa
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
@mboukhalfa
Copy link
Member

/hold
@essamgouda97 can you squash commits

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2024
@essamgouda97 @adowair
translate setup/_index.md
1a2d420 
typo

Co-authored-by: Mohammed BOUKHALFA <[email protected]>

spelling

Co-authored-by: Mohammed BOUKHALFA <[email protected]>

bare metal translation

Update content/ar/docs/setup/_index.md

Co-authored-by: Ali Dowair <[email protected]>

Update content/ar/docs/setup/_index.md

Co-authored-by: Ali Dowair <[email protected]>

Update content/ar/docs/setup/_index.md

Co-authored-by: Ali Dowair <[email protected]>

Update content/ar/docs/setup/_index.md

Co-authored-by: Ali Dowair <[email protected]>

Update content/ar/docs/setup/_index.md

Co-authored-by: Ali Dowair <[email protected]>

Update content/ar/docs/setup/_index.md

Co-authored-by: Ali Dowair <[email protected]>

Update content/ar/docs/setup/_index.md

Co-authored-by: Ali Dowair <[email protected]>

Update content/ar/docs/setup/_index.md

Co-authored-by: Ali Dowair <[email protected]>

Update content/ar/docs/setup/_index.md

Co-authored-by: Ali Dowair <[email protected]>

update windows translation

Update content/ar/docs/setup/_index.md

Co-authored-by: Ali Dowair <[email protected]>

Update content/ar/docs/setup/_index.md

Co-authored-by: Ali Dowair <[email protected]>
@essamgouda97 essamgouda97 force-pushed the ar/translate-setup-_index branch from 81e8abe to 1a2d420 Compare April 24, 2024 11:24
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adowair, mboukhalfa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboukhalfa
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 1, 2024
@mboukhalfa mboukhalfa mentioned this pull request May 4, 2024
Open
@nate-double-u
Copy link
Contributor

nate-double-u commented Jul 4, 2024 •
edited
Loading

This looks like this PR needs the lgtm reapplied (it's got an approval). Unfortunately I don't read Arabic, so can't confirm there weren't changes made during updates. @adowair, could you confirm? If so, then I can reapply the LGTM and we can get this in.

@adowair
Copy link

adowair commented Jul 5, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: efa7d4756086f263c1ed7152f25a6fbc1e2983af

@k8s-ci-robot k8s-ci-robot merged commit 4bbf02b into kubernetes:dev-1.29-ar.1 Jul 5, 2024
2 checks passed
@essamgouda97 essamgouda97 deleted the ar/translate-setup-_index branch July 7, 2024 01:00
@SsomsakTH SsomsakTH mentioned this pull request Jul 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adowair adowair adowair approved these changes

@mboukhalfa mboukhalfa mboukhalfa approved these changes

@natalisucks natalisucks Awaiting requested review from natalisucks

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees

@mboukhalfa mboukhalfa

@adowair adowair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ar Issues or PRs related to Arabic language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@essamgouda97 @mboukhalfa @k8s-ci-robot @nate-double-u @adowair