-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ar] Translate setup/_index.md #44289
Conversation
Welcome @essamgouda97! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/label language/ar |
@essamgouda97: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/language ar |
/language en |
Thank you @essamgouda97 for this effort! I cannot seem to find a link that will show me a preview of this page. Have you been able to find it? https://deploy-preview-44289--kubernetes-io-main-staging.netlify.app/ takes us to the homepage, but I'm not able find the page of this PR manually by manipulating the URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
شكراً على المشاركة @essamgouda97، أقترح إعادة صياغة الترجمة حيث أنها قريبة جداً إلى الترجمة الآلية. اقترح قراءة النص الإنجليزي كاملاً إستخراج المعاني والأهداف ومن ثم تحرير الترجمة بأسلوبك الخاص.
@adowair any idea what's missing ? How does that work anyways 😆 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here are some comments
you can squash commits and move from draft to ready for review |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mboukhalfa @adowair I want one more shot at improving the language used this weekend then I will squash and mark as Ready for review. |
This reverts commit 7cdc9a3.
Co-authored-by: Ali Dowair <[email protected]>
Co-authored-by: Ali Dowair <[email protected]>
Co-authored-by: Ali Dowair <[email protected]>
Co-authored-by: Mohammed BOUKHALFA <[email protected]>
@mboukhalfa @adowair this being my first OSS contribution ever I am bit noob-ish, I rebased off |
I cannot see what is really causing this probably you are not forking the correct branch ? fork |
This PR is superseded by #45094 |
This PR will create a new file contents/docs/ar/setup/_index.md that is translated into arabic following the english docs.
Following the plan in this PR: #37546 more file will be picked. The base branch is currently
main
until a branch is created for arabic.