Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace hardcoded GCS URIs with dl.k8s.io #41444

Closed
wants to merge 1 commit into from

Conversation

kumiDa
Copy link

@kumiDa kumiDa commented Jun 3, 2023

As per the initiative kubernetes/k8s.io#1571 to move away from the use of GCP project google-containers, this PR fixes kubernetes/k8s.io#2396

The existent references to https://storage.googleapis.com/kubernetes-release in the repo are replaced appropriately with https://dl.k8s.io/

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mrbobbytables, seokho-son for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from jihoon-seo June 3, 2023 17:30
@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Jun 3, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim June 3, 2023 17:30
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 3, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @kumiDa!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 3, 2023
@dipesh-rawat
Copy link
Member

@kumiDa Thanks for your contribution!

It seems that this PR incorporates modifications to files in multiple languages (en, ko). Documentation team follows different procedures for each localization, and we typically don't merge PR that impact multiple languages simultaneously. My suggestion is to divide this into several pull requests, each concentrating on a specific language.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This 'en' change is duplicated by #41072

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This 'en' change is duplicated by #41072

@netlify
Copy link

netlify bot commented Jun 3, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e15356a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/647b78987b35f500088a03d0
😎 Deploy Preview https://deploy-preview-41444--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kumiDa
Copy link
Author

kumiDa commented Jun 3, 2023

@kumiDa Thanks for your contribution!

It seems that this PR incorporates modifications to files in multiple languages (en, ko). Documentation team follows different procedures for each localization, and we typically don't merge PR that impact multiple languages simultaneously. My suggestion is to divide this into several pull requests, each concentrating on a specific language.

Thanks for pointing the respective PRs that are open which introduce these changes to en version of the docs.
I also notice that the changes are propagated to the ko version of the docs as well.
So this PR would essentially be a redundant one, let me go ahead and close this PR.

@kumiDa kumiDa closed this Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate and migrate away from gs://kubernetes-release
3 participants